Skip to content

Commit

Permalink
[8.7] [Security Solutions] Fix module name cut under beats overview d…
Browse files Browse the repository at this point in the history
…ashboard (#151843) (#151864)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solutions] Fix module name cut under beats overview
dashboard (#151843)](#151843)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-02-22T14:06:48Z","message":"[Security
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.7.0","v8.8.0"],"number":151843,"url":"#151843
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151843
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
  • Loading branch information
kibanamachine and machadoum committed Feb 22, 2023
1 parent fd572bc commit c50492d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ const NoMarginTopFlexItem = styled(EuiFlexItem)`
`;

const AccordionContent = styled.div`
margin-top: 8px;
padding-top: 8px;
`;

const OverviewHostStatsComponent: React.FC<OverviewHostProps> = ({ data, loading }) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const NoMarginTopFlexItem = styled(EuiFlexItem)`
`;

const AccordionContent = styled.div`
margin-top: 8px;
padding-top: 8px;
`;

const OverviewNetworkStatsComponent: React.FC<OverviewNetworkProps> = ({ data, loading }) => {
Expand Down

0 comments on commit c50492d

Please sign in to comment.