Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Fix module name cut under beats overview dashboard #151843

Merged
merged 1 commit into from Feb 22, 2023
Merged

[Security Solutions] Fix module name cut under beats overview dashboard #151843

merged 1 commit into from Feb 22, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Feb 22, 2023 •
edited by kibanamachine

issue: #151663

Summary

Probably due to some changes when converting EuiAccordion from Sass to Emotion CSS border-top leaks and breaks the component height calculation.

Before

Screenshot 2023-02-22 at 11 34 46

After

Screenshot 2023-02-22 at 11 33 20

Checklist

@machadoum machadoum self-assigned this Feb 22, 2023
@machadoum machadoum added release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.7.0 labels Feb 22, 2023
@machadoum machadoum marked this pull request as ready for review February 22, 2023 10:40
@machadoum machadoum requested a review from a team as a code owner February 22, 2023 10:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum added the bug Fixes for quality problems that affect the customer experience label Feb 22, 2023
@machadoum machadoum enabled auto-merge (squash) February 22, 2023 11:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit e47b42f into elastic:main Feb 22, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
@machadoum
[Security Solutions] Fix module name cut under beats overview dashboa…
a1a8006 
…rd (elastic#151843)

issue: elastic#151663

## Summary
Probably due to some changes when converting `EuiAccordion` [from Sass
to Emotion
CSS](elastic/eui@922a789)
`border-top` leaks and breaks the component height calculation.

### Before
<img width="1120" alt="Screenshot 2023-02-22 at 11 34 46"
src="https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png">

### After
<img width="1109" alt="Screenshot 2023-02-22 at 11 33 20"
src="https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png">

### Checklist

(cherry picked from commit e47b42f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 22, 2023
@kibanamachine @machadoum
[8.7] [Security Solutions] Fix module name cut under beats overview d…
c50492d 
…ashboard (#151843) (#151864)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solutions] Fix module name cut under beats overview
dashboard (#151843)](#151843)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-02-22T14:06:48Z","message":"[Security
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.7.0","v8.8.0"],"number":151843,"url":"#151843
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151843
Solutions] Fix module name cut under beats overview dashboard
(#151843)\n\nissue:
#151663
Summary\r\nProbably due to some changes when converting `EuiAccordion`
[from Sass\r\nto
Emotion\r\nCSS](https://github.com/elastic/eui/commit/922a789ae204029a050f0bef79bf96d2438dab5a)\r\n`border-top`
leaks and breaks the component height calculation.\r\n\r\n\r\n###
Before\r\n<img width=\"1120\" alt=\"Screenshot 2023-02-22 at 11 34
46\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595311-d0abbdea-88eb-4403-b76a-a1c5f226a726.png\">\r\n\r\n\r\n###
After\r\n<img width=\"1109\" alt=\"Screenshot 2023-02-22 at 11 33
20\"\r\nsrc=\"https://user-images.githubusercontent.com/1490444/220595190-9ab66660-cebf-4589-84ad-a21449f816b9.png\">\r\n\r\n\r\n\r\n###
Checklist","sha":"e47b42f05e6a7dd3d3d14c353addff38f797e14a"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
@stephmilovic stephmilovic mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamster10 jamster10 jamster10 approved these changes

Assignees

@machadoum machadoum

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @jamster10