return null after warning

elastic · Nov 30, 2023 · d163bc1 · d163bc1
1 parent 2cdac29
commit d163bc1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/x-pack/plugins/stack_connectors/server/connector_types/lib/servicenow/service.test.ts b/x-pack/plugins/stack_connectors/server/connector_types/lib/servicenow/service.test.ts
@@ -1062,13 +1062,15 @@ describe('ServiceNow service', () => {
           },
         }));
 
-        await service.closeIncident({ incidentId: 'xyz', correlationId: null });
+        const res = await service.closeIncident({ incidentId: 'xyz', correlationId: null });
 
+        expect(requestMock).toHaveBeenCalledTimes(1);
         expect(logger.warn.mock.calls[0]).toMatchInlineSnapshot(`
-        Array [
-          "[ServiceNow][CloseIncident] No incident found with incidentId: xyz.",
-        ]
-      `);
+          Array [
+            "[ServiceNow][CloseIncident] No incident found with incidentId: xyz.",
+          ]
+        `);
+        expect(res).toBeNull();
       });
 
       test('it should log warning if found incident is closed', async () => {

diff --git a/x-pack/plugins/stack_connectors/server/connector_types/lib/servicenow/service.ts b/x-pack/plugins/stack_connectors/server/connector_types/lib/servicenow/service.ts
@@ -299,6 +299,8 @@ export const createExternalService: ServiceFactory = ({
             logger.warn(
               `[ServiceNow][CloseIncident] No incident found with incidentId: ${incidentId}.`
             );
+
+            return null;
           }
         }
       } else if (correlationId) {