Skip to content

Commit

Permalink
Revert screenshot comparison tests to old threshold parameters (#17626)
Browse files Browse the repository at this point in the history
Applies to Tagcloud. #17597 made them too strict, causing them to fail in CI.
  • Loading branch information
thomasneirynck committed Apr 10, 2018
1 parent f03b4fd commit e3d81bf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/core_plugins/tagcloud/public/__tests__/tag_cloud.js
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ describe('tag cloud tests', function () {

await fromNode(cb => tagCloud.once('renderComplete', cb));

const mismatchedPixels = await imageComparator.compareDOMContents(domNode.innerHTML, 512, 512, simpleloadPng, 0.35);
const mismatchedPixels = await imageComparator.compareDOMContents(domNode.innerHTML, 512, 512, simpleloadPng, 0.50);
expect(mismatchedPixels).to.be.lessThan(64);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import basicdrawPng from './basicdraw.png';
import afterresizePng from './afterresize.png';
import afterparamChange from './afterparamchange.png';

const THRESHOLD = 0.35;
const THRESHOLD = 0.65;
const PIXEL_DIFF = 64;

describe('TagCloudVisualizationTest', function () {
Expand Down

0 comments on commit e3d81bf

Please sign in to comment.