Revert to old threshold parameters for screenshot tests #17626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
test
Feature:Visualizations
💚 Build Succeeded |
|
jenkins, test this |
💚 Build Succeeded |
|
jenkins, test this |
💔 Build Failed |
|
failed on management UI-test. jenkins, test this |
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 10, 2018
…ic#17626) Applies to Tagcloud. elastic#17597 made them too strict, causing them to fail in CI.
thomasneirynck
added a commit
that referenced
this pull request
Apr 11, 2018
* Change hashing algo of tagcloud rotations (#17597) pulls in TimR's changes (#17594) to the hashing algorithm. This also replaces the reference screenshots to match the new rotations. * Revert screenshot comparison tests to old threshold parameters (#17626) Applies to Tagcloud. #17597 made them too strict, causing them to fail in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the params stricter has made the test fail in CI https://kibana-ci.elastic.co/job/elastic-kibana-master/24.
Reverting to old settings.