Skip to content

Commit

Permalink
Tabbed modal component (#179613)
Browse files Browse the repository at this point in the history
## Summary

This splits out the work created in
#179037, so that we might have a
smaller PR to be review that is also single purpose.

This PR introduces the tabbed modal component, alongside visual API for
constructing a modal with tabbed experience within Kibana. It mostly
builds off the EUI modal component, with allowance to construct a modal
declaratively, and also supports managing state for the modal. See
`IModalTabDeclaration`

At the moment this component is quite rudimentary and might be evolved,
but as of now it has mostly been created to support the work for
redesigning the share experience for dashboard, lens and canvas.

It can be reviewed by through the shared_ux storybook; `yarn storybook
shared_ux`. Examples for it's usage have also been included.


## Visuals

<img width="598" alt="Screenshot 2024-03-28 at 12 07 01"
src="https://github.com/elastic/kibana/assets/7893459/830752c8-73c9-435a-94cb-e28442b12941">




Co-authored-by: rshen91 <rshen@elastic.co>
  • Loading branch information
eokoneyo and rshen91 committed Apr 4, 2024
1 parent f385496 commit f046050
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/shared-ux/modal/tabbed/src/context/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function ModalContextProvider<T extends Array<ITabDeclaration<Record<stri
}, []);

const [state, dispatch] = useReducer(
combineReducers(reducersMap!),
combineReducers(reducersMap),
initialModalState.current,
createInitialState
);
Expand Down

0 comments on commit f046050

Please sign in to comment.