Tabbed modal component #179613
Merged
Tabbed modal component #179613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
added
release_note:skip
|
/ci |
rshen91
reviewed
Mar 28, 2024
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
eokoneyo
force-pushed
the
feat/create-tabbed-modal
branch
from
65012a4
to
e67bc4a
Compare
rshen91
approved these changes
Apr 4, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.14.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This splits out the work created in #179037, so that we might have a smaller PR to be review that is also single purpose.
This PR introduces the tabbed modal component, alongside visual API for constructing a modal with tabbed experience within Kibana. It mostly builds off the EUI modal component, with allowance to construct a modal declaratively, and also supports managing state for the modal. See
IModalTabDeclarationAt the moment this component is quite rudimentary and might be evolved, but as of now it has mostly been created to support the work for redesigning the share experience for dashboard, lens and canvas.
It can be reviewed by through the shared_ux storybook;
yarn storybook shared_ux. Examples for it's usage have also been included.Visuals