Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Platform] - Step 4 of SO migrations, marking as share capable #114548

Closed
yctercero opened this issue Oct 11, 2021 · 12 comments
Closed
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0

Comments

@yctercero
Copy link
Contributor

yctercero commented Oct 11, 2021

As part of 8.0 SO migrations need to mark certain SOs as "share capable".

See docs https://www.elastic.co/guide/en/kibana/master/sharing-saved-objects.html

An example PR of this is here.

Security Solution SOs can be found here.

So what's it means for our SOs? Alerting has marked rules as share-capable, does this mean all our SOs need to now be made share-capable as well?

Do agnostic ones need to be marked?

@yctercero yctercero added v8.0.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team labels Oct 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero
Copy link
Contributor Author

Confirmed with @michaelolo24 that timeline SOs have been made "share-capable". cc @jonathan-buttner

@michaelolo24
Copy link
Contributor

For reference: #113552

@yctercero
Copy link
Contributor Author

Also (thanks Mike) - cases is all set here as well ✅

@yctercero
Copy link
Contributor Author

NOTE: siem-detection-engine-rule-status being taken care of by @spong (thank you!)

@yctercero
Copy link
Contributor Author

NOTE: security-rules are all agnostic 🚀 Thanks @spong and @peluja1012 for looking into it.

@paul-tavares
Copy link
Contributor

@yctercero I'm about to start looking into this for things associated with Artifacts and Exceptions (for trusted apps, event filters) and want to confirm: Our artifacts and exceptions SOs are all space agnostic, does that mean we don't have to do anything? 😁

@paul-tavares
Copy link
Contributor

Hi @yctercero ,

Here is an update for SO types:

  • endpoint:user-artifact-manifest and
  • endpoint:user-artifact

Both of these SO types are namespaceType: 'agnostic' (see here ) and my understanding is that for space agnostic objects, we don't need to do any migration.

These, as well as exception-list-agnostic, do reference Fleet Package Policies IDs (SOs as well), but those are also namespaceType: 'agnostic (see here)

@yctercero
Copy link
Contributor Author

Hi @yctercero ,

Here is an update for SO types:

  • endpoint:user-artifact-manifest and
  • endpoint:user-artifact

Both of these SO types are namespaceType: 'agnostic' (see here ) and my understanding is that for space agnostic objects, we don't need to do any migration.

These, as well as exception-list-agnostic, do reference Fleet Package Policies IDs (SOs as well), but those are also namespaceType: 'agnostic (see here)

We confirmed that's true, for agnostic we do not need to make them share-capable.

@rylnd
Copy link
Contributor

rylnd commented Oct 15, 2021

PR to update our security-solution-signals-migration SOs: #115281

@jportner
Copy link
Contributor

I spoke to @rylnd about the security-solution-signals-migration object type, which are used in the Detection Alerts Migration APIs:

  1. These objects are only accessed through these APIs
  2. These objects are short-lived (the user will upgrade Kibana, then call these APIs, which creates and subsequently deletes these saved objects)
  3. These objects are always isolated to an individual space, they won’t need to be shared in the future (and they will eventually be superseded by “alerts-as-data”)
  4. There are no references from other objects to these objects
  5. There are no references from these objects to other objects

With that in mind, I don't think we need to convert these to become share-capable, we can leave them as isolated (namespaceType: 'single') 👍

FrankHassanabad added a commit that referenced this issue Oct 19, 2021
… action status, and exception lists multiple space shareable (#115427)

## Summary

See #114548

Makes the following saved objects multiple-isolated:
* siem-detection-engine-rule-status
* exception-list
* siem-detection-engine-rule-actions

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@yctercero
Copy link
Contributor Author

Closing out as it seems all SOs have been taken care of. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0
Projects
None yet
Development

No branches or pull requests

6 participants