Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops] Refactor alerting task runner - AlertingEventLog class #131540

Closed
ymao1 opened this issue May 4, 2022 · 1 comment · Fixed by #131670
Closed

[Response Ops] Refactor alerting task runner - AlertingEventLog class #131540

ymao1 opened this issue May 4, 2022 · 1 comment · Fixed by #131670
Assignees
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 4, 2022

Meta issue: #124206

As a step towards refactoring the task runner, we want to encapsulate all event log transactions that occur during task running into a class (AlertingEventLog) with the following public functions:

  • initialize() - initializes the class with all the data required to populate the common metadata fields
  • start() - sets the start time for the transaction (shared between execute-start and execute and writes out the execute-start event
  • logActiveAlert()/logNewAlert()/logRecoveredAlert()/logTimeout()
  • complete() - sets metrics data and any errors/warnings for rule run and writes out execute event

Ensure this class is thoroughly unit-tested.

@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels May 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants