Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Refactor alerting task runner - combine loadRuleAttributesAndRun() and validateAndExecuteRule() #131544

Closed
Tracked by #124206
ymao1 opened this issue May 4, 2022 · 3 comments · Fixed by #132079
Closed
Tracked by #124206

[Response Ops] Refactor alerting task runner - combine loadRuleAttributesAndRun() and validateAndExecuteRule() #131544

ymao1 opened this issue May 4, 2022 · 3 comments · Fixed by #132079
Assignees
@pmuellr
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 4, 2022 •
edited
Loading

Meta issue: #124206

As a step towards refactoring the task runner, combine loadRuleAttributesAndRun() and validateAndExecuteRule() functions and extract it into a library function with a complete set of unit tests
@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels May 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 added the blocked label May 4, 2022
@ymao1 ymao1 mentioned this issue May 4, 2022
Closed
@ymao1
Copy link
Contributor Author

ymao1 commented May 6, 2022 •
edited
Loading

Unblocking since PR submitted for #131540

Should branch off of this PR (if not merged). Edit: it's merged

@ymao1 ymao1 removed the blocked label May 6, 2022
@ymao1
Copy link
Contributor Author

ymao1 commented May 9, 2022

I did a quick POC to see what this might look like: ymao1#9. Whoever picks this issue up can feel free to use or not use :)

@pmuellr pmuellr self-assigned this May 10, 2022
pmuellr added a commit to pmuellr/kibana that referenced this issue May 11, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
afd41f4 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
@pmuellr pmuellr mentioned this issue May 11, 2022
Merged
2 tasks
pmuellr added a commit to pmuellr/kibana that referenced this issue May 16, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
359bc5b 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
pmuellr added a commit to pmuellr/kibana that referenced this issue May 18, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
06b2769 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
pmuellr added a commit to pmuellr/kibana that referenced this issue May 19, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
ae28ddc 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
pmuellr added a commit to pmuellr/kibana that referenced this issue May 25, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
39fb0b5 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
pmuellr added a commit to pmuellr/kibana that referenced this issue May 26, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
4de3842 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
pmuellr added a commit to pmuellr/kibana that referenced this issue Jun 2, 2022
@pmuellr
WIP [ResponseOps]: Refactor alerting task runner - combine loadRuleAt…
a152bfd 
…tributesAndRun() and validateAndExecuteRule()

resolves elastic#131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task manager, into a separate module.

meta issue: elastic#124206
@pmuellr pmuellr mentioned this issue Jun 7, 2022
Closed
8 tasks
pmuellr added a commit that referenced this issue Jun 14, 2022
@pmuellr
[ResponseOps]: Refactor alerting task runner - combine loadRuleAttrib…
04e259a 
…utesAndRun() and validateAndExecuteRule() (#132079)

resolves #131544

Extract the `loadRuleAttributesAndRun()` and `validateAndExecuteRule()`
methods from the alerting task runner, into a separate module.

meta issue: #124206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuellr pmuellr

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
3 participants
@pmuellr @ymao1 @elasticmachine