Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops] Refactor alerting task runner - refactor determination of active/new/recovered alerts #131546

Closed
Tracked by #124206
ymao1 opened this issue May 4, 2022 · 2 comments · Fixed by #135069
Closed
Tracked by #124206
Assignees
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 4, 2022

Meta issue: #124206

As a step towards refactoring the task runner, move the determination of new/active/recovered alerts to the AlertFactory. The AlertFactory contains all the information needed to make this determination. We should be able to add functions to getNewAlerts(), getActiveAlerts() and getRecoveredAlerts() and store it in the alert factory so even if they are called multiple times, the calculations are only done once. Keeping in mind that we should not be exposing these functions to the rule type executors (we want them only to use create() and done()). We should also see if we can move the functionality in trackAlertDurations into the alert factory so getActiveAlerts() returns alerts with updated duration and getRecoveredAlerts() returns alerts with updated duration and end time set.

@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels May 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 14, 2022

Unblocking as #131544 is close to getting merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
2 participants