Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Refactor alerting task runner - combine logActiveAndRecoveredAlerts and generateNewAndRecoveredAlertEvents #131547

Closed
Tracked by #124206
ymao1 opened this issue May 4, 2022 · 2 comments · Fixed by #136763
Closed
Tracked by #124206

[Response Ops] Refactor alerting task runner - combine logActiveAndRecoveredAlerts and generateNewAndRecoveredAlertEvents #131547

ymao1 opened this issue May 4, 2022 · 2 comments · Fixed by #136763
Assignees
@ymao1
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 4, 2022 •
edited
Loading

Meta issue: #124206

As a step towards refactoring the task runner, we want to combine the logActiveAndRecoveredAlerts and generateNewAndRecoveredAlertEvents functions so we're logging to the server and the event log in a single place. Consider extracting it to a library function with a complete set of unit tests.
@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels May 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 added the blocked label May 4, 2022
@ymao1 ymao1 mentioned this issue May 4, 2022
Closed
@ymao1 ymao1 mentioned this issue May 16, 2022
Closed
@pmuellr pmuellr mentioned this issue Jun 7, 2022
Closed
8 tasks
@ymao1 ymao1 removed the blocked label Jul 13, 2022
@ymao1
Copy link
Contributor Author

ymao1 commented Jul 13, 2022

Unblocking bc #131546 is close to being done :)

@ymao1 ymao1 self-assigned this Jul 20, 2022
@ymao1 ymao1 mentioned this issue Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymao1 ymao1

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Response Ops] Refactor task runner - separate function for logging alerts ymao1/kibana
2 participants
@ymao1 @elasticmachine