Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Long full name and description of the Timeline Template is not shown on the Templates drop-down on 'Apply Timeline template' flyout #131614

Closed
ghost opened this issue May 5, 2022 · 8 comments
Closed

[Security Solution] Long full name and description of the Timeline Template is not shown on the Templates drop-down on 'Apply Timeline template' flyout #131614

ghost opened this issue May 5, 2022 · 8 comments
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0

Comments

@ghost
Copy link

ghost commented May 5, 2022

Describe the bug:

  • Long full name and description of the Timeline Template is not shown on the Templates drop-down on 'Apply Timeline template' flyout

Kibana/Elasticsearch Stack version:

Version: 8.3.0 SNAPSHOT
Build: 52512
Commit: df225b213b188c81888141cee2ec191424fc0649

Pre-conditions:

  1. Elastic Search should be up and running
  2. Kibana should be up and running
  3. Create a custom rule.
  4. Create Timeline Templates with long name and long description with and without spaces.

Steps to reproduce:

  1. Navigate to Rules tab under Security
  2. Select a custom rule.
  3. Click on Bulk actions.
  4. Select 'Apply Timeline Template' option from the dropdown.
  5. 'Apply Timeline Template' sheet will open from the right.
  6. Select the 'None' box.
  7. Templates drop-down will get open.

Current behavior:

  • Long full name and description of the Timeline Template is not shown on the Templates drop-down on 'Apply Timeline template' flyout.

Expected behavior:

  • Long full name and description of the Timeline Template should be shown on the Templates drop-down on 'Apply Timeline template' flyout.

What's not working: This issue is occurring for Long full name and description of the Timeline Template with spaces as well.

Screenshots:

Rules.-.Kibana.-.Google.Chrome.2022-05-04.13-18-07.mp4

image
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0 labels May 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented May 5, 2022

Additional Observations:

  • 'Black Star' is not shown in front of favorite Timeline Templates on the Templates drop-down having the following:
  1. Long Template name with long description.
  2. Long Template name with short description.
  3. Short Template name with long description.
Rules.-.Kibana.-.Google.Chrome.2022-05-04.13-32-08.mp4

@ghost ghost assigned ghost and MadameSheema and unassigned ghost May 5, 2022
@MadameSheema MadameSheema added Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team and removed v8.3.0 labels May 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror mentioned this issue May 11, 2022
Closed
@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management and removed triage_needed labels May 11, 2022
@banderror banderror removed their assignment May 11, 2022
@banderror
Copy link
Contributor

Thank you @prachigupta-qasource, these are great observations! More to the list of issues with the timeline template selector component: #128740

@vitaliidm vitaliidm mentioned this issue Jun 29, 2022
Merged
4 tasks
@vitaliidm
Copy link
Contributor

vitaliidm commented Jun 29, 2022 •
edited
Loading

@yiyangliu9286 in current state, there is a default browser title displayed when hover mouth over the timeline item

Screenshot 2022-06-29 at 17 39 36

Is this way sufficient enough?

If not, would something like this(adding tooltip) make it better?

Screenshot 2022-06-29 at 17 49 37

@yiyangliu9286
Copy link

@yiyangliu9286 in current state, there is a default browser title displayed when hover mouth over the timeline item

Screenshot 2022-06-29 at 17 39 36

Is this way sufficient enough?

If not, would something like this(adding tooltip) make it better?

Screenshot 2022-06-29 at 17 49 37

Hi @vitaliidm, hover with tooltips might be a better way to go for, thanks for flagging this!

vitaliidm added a commit that referenced this issue Jul 4, 2022
@vitaliidm
[Security Solution] fixes display of long title and description in ti…
6efc9da 
…meline template controller (#135426)

## Summary

Addresses #131614

- added tooltips to both title and description of timeline template option, trims long title/description correctly with adding '...' to trimmed text
- changes width of flex items, so favourite button won't get hidden in overflow, if timeline title too long

### Before
<img width="1521" alt="Screenshot 2022-06-29 at 17 39 36" src="https://user-images.githubusercontent.com/92328789/176491751-d6db7301-58d3-4b67-9913-fb496dc4fe09.png">

### After
<img width="1520" alt="Screenshot 2022-06-29 at 17 49 37" src="https://user-images.githubusercontent.com/92328789/176492869-32774bc9-7a15-4fa5-bf1f-59cafc6f9698.png">

### Checklist

- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Release note
fixes display of long title and description in timeline template controller on rule details page and on bulk apply timeline template
@vitaliidm
Copy link
Contributor

vitaliidm commented Jul 4, 2022 •
edited
Loading

@deepikakeshav-qasource, @prachigupta-qasource, issue has been addressed in #135426

@vitaliidm vitaliidm assigned ghost and unassigned vitaliidm Jul 4, 2022
@vitaliidm vitaliidm added the fixed label Jul 4, 2022
@vitaliidm vitaliidm assigned ghost and unassigned ghost Jul 4, 2022
@vitaliidm vitaliidm added the QA:Ready for Testing Code is merged and ready for QA to validate label Jul 4, 2022
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this issue Jul 5, 2022
@vitaliidm
[Security Solution] fixes display of long title and description in ti…
c9ffd9c 
…meline template controller (elastic#135426)

## Summary

Addresses elastic#131614

- added tooltips to both title and description of timeline template option, trims long title/description correctly with adding '...' to trimmed text
- changes width of flex items, so favourite button won't get hidden in overflow, if timeline title too long

### Before
<img width="1521" alt="Screenshot 2022-06-29 at 17 39 36" src="https://user-images.githubusercontent.com/92328789/176491751-d6db7301-58d3-4b67-9913-fb496dc4fe09.png">

### After
<img width="1520" alt="Screenshot 2022-06-29 at 17 49 37" src="https://user-images.githubusercontent.com/92328789/176492869-32774bc9-7a15-4fa5-bf1f-59cafc6f9698.png">

### Checklist

- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Release note
fixes display of long title and description in timeline template controller on rule details page and on bulk apply timeline template
@ghost
Copy link

ghost commented Jul 19, 2022

Hi @vitaliidm
We have validated this issue on the latest 8.4.0-Snapshot build and observed that the issue is fixed. Please find below the testing details:

  • Tooltip is shown for long full name and description of the Timeline Template on the Templates drop-down on 'Apply Timeline template' flyout
  • 'Black Star' is shown in front of favorite Timeline Templates on the Templates drop-down having the following:
  1. Long Template name with long description. PASS
  2. Long Template name with short description. PASS
  3. Short Template name with long description. PASS

Build Details:

VERSION : 8.4.0 SNAPSHOT
BUILD: 54571
COMMIT: f53c703c4e8851adc51da800a0965eaaae4136fe

Screen-Recording:

Rules.-.Kibana.-.Google.Chrome.2022-07-19.13-22-38.mp4

Hence, We are closing this issue and marking it as QA Validated.

Thanks!

@ghost ghost closed this as completed Jul 19, 2022
@ghost ghost added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 19, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.4 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@banderror @elasticmachine @MadameSheema @yiyangliu9286 @vitaliidm