[Lens] Metric Vis 8.4 Follow-ups

[drewdaemon]

Aiming to get these in for 8.4

• [Lens] Adding a formula metric on the new metric chart creates an error #137248

• Impose rounded corners on dashboard (source) — Resolved in [Lens] add rounded corners to metric vis #137597

• Color stops UI has light background in dark mode [Lens] Fix wrong theme bug in gauges and new metric viz #137340

• Add color swatch preview to primary metric dimension when static color is set (source) [Lens] Add color swatch to primary metric dimension #138053

• Functional test coverage - [8.4] [Lens] metric visualization functional tests (#137731) #138289

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[flash1293]

@stratoula I think you mentioned you already fixed the color stop UI somewhere else, right?

[stratoula]

Yes I did! On my dimension panel redesign PR!

[flash1293]

@stratoula As this PR won't go into 8.4, is it possible to backport just that bit?

[stratoula]

Joe my fix is to remove the background colour from the fly out. It is one of Michael's changes. We can't apply this in 8.4 but we can check for dark mode and apply the correct background. I will take care of it tomorrow!

[drewdaemon]

we can check for dark mode and apply the correct background

I know the color stops UI looks right on the legacy metric vis. It must be doing this 👍

[stratoula]

Really? This is so weird, it is the same component 🤔

[stratoula]

@andrewctate it also happens in gauges. I know what it going wrong, I will fix them both tomorrow!

[drewdaemon]

Closing as all tasks for 8.4 are complete or have been pushed to the 8.5 list: #137769.