[Lens] Fix wrong theme bug in gauges and new metric viz #137340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
stratoula
added
v8.4.0
v8.5.0
auto-backport
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2022
* [Lens] Fix wrong theme bug in gauges and new metric viz * Fix tests (cherry picked from commit 2d554c0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #137326
This fixes a bug that exists on gauges (released bug) and new metric (non released bug). The palette configuration flyout appears with light background on the dark mode. This is the most obvious bug. There are other things that dont appear with the dark mode look and feel but they are not so obvious.
The problem is that the toolbar and the dimension editor components are not wrapped under the theme service. This PR fixes it.