[Lens] Metric Vis 8.5 Follow-ups

[drewdaemon]

• Suggested/auto prefix for secondary metric (source) — [Lens] Auto mode for secondary metric prefix #138167
• If not enough vertical space, make visualization scrollable. Can check if enough vertical space by calculating min visualization height based on a 64 px min height for each row of tiles. — [Lens] make metric visualization scrollable when too tall #138178
• add an option to display infinity instead of "Max value" and "Min value" in the color stops UI for metric visualization max / min — [Lens] add display-infinity option to custom palette editor #139061
• Support dimension editor field format controls — [Lens] add format selector to new metric vis #139018
• Functional test coverage — [Lens] metric visualization functional tests #137731
• Fix clear layer function — [Lens] clear metric visualization state #139154
• Validate max accessor — [Lens] clear metric visualization state #139154
• Pass NaN instead of null as value when no data. (see Metric vis typing forbid null values but they are handled all the same elastic-charts#1779)
• Migrate legacy metric internal ID to lnsLegacyMetric and lnsNewMetric to lnsMetric — [Lens] migrate metric visualization IDs #139251
• [Lens] Metric vis fails on transition if suffix is set #139166
• Code clean-up
  • [Lens] add new metric visualization #136567 (comment) (addressed in [Lens] clear metric visualization state #139154)
  • [Lens] add new metric visualization #136567 (comment) (addressed in [Lens] Auto mode for secondary metric prefix #138167)
• Remove "magic key" hack once Metric visualization shows phantom tiles after data change elastic-charts#1778 is fixed — [Lens] dont force metric vis re-render #140228
• Deduplicate min tile height once Expose minimum metric tile height in chart theme elastic-charts#1788 is done — [Lens] use min metric height from theme #141683

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[drewdaemon]

Suggested/auto prefix for secondary metric

I know this one seems trivial, but we may only be able to support part of this ask. The good news is that it is easy to give the prefix a helpful initial value based on the dimension name.

However, keeping it in sync whenever the dimension name changes is not currently possible because of a boundary in the code between the visualization and the datasource classes. I.e. there's currently no way for the visualization (which handles the prefix) to know when a dimension name has changed (happens in the datasource).

We could consider strengthening the communication channel between datasource and visualization to support something like this, but there may be architectural drawbacks to associating them more closely.

Any thoughts @flash1293 ?

[flash1293]

@andrewctate We have a similar kind of problem with the axis names in xy - the way it's solved is the following:

• As long as there is no prefix configured for the secondary metric, the name of the table column is used as default (the renderer has access to this information)
• If a custom name is set, it's passed to the expression argument from the visualization state (which can be empty string as well)

This way the visualizaiton doesn't have to store the default dimension name in its own state

[gvnmagni]

I had the chance to talk with @markov00 about empty tiles and title+subtitle for panels (when we have a break-down-by). I'm posting here a couple of images as an example but I wanted to mention that he will probably reach out to align details between Lens and Charts

[flash1293]

@gvnmagni I'm not sure I fully get how empty tiles are handled - if there are multiple empty tiles will they all be rendered with the black line in the bottom right? Like for the case with a fully empty 3x2 grid

[gvnmagni]

Yes exactly, each empty tile would have that little line suggesting that there should be something but given the filters (or any other reason) we don't have it. We can see a difference with the last couple of tiles into the image that has no border, this case is when we have a 5x3 grid but we only show top 13 values and we obtain empty space that would never be filled, it's not a matter of filters

[flash1293]

Makes sense, thanks!

[drewdaemon]

add an option to display infinity instead of "Max value" and "Min value" in the color stops UI for metric visualization max / min

@ghudgins we wanted to consult you before committing to this course of action. The idea is that showing the infinity symbol in the context of a single-value metric visualization is more clear than "Max value" and "Min value." WDYT?

Same discussion back in January: #123756 (comment)

[ghudgins]

sounds good - sorry for the delay

[flash1293]

All done!