Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Unlink from library / Save to library actions do not work for maximized panels #139915

Closed
Tracked by #144752
alexwizp opened this issue Sep 1, 2022 · 4 comments · Fixed by #150338
Closed
Tracked by #144752

[Dashboard] Unlink from library / Save to library actions do not work for maximized panels #139915

alexwizp opened this issue Sep 1, 2022 · 4 comments · Fixed by #150338
Assignees
@cqliu1
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Sep 1, 2022

Kibana version:
main, >7.17

Describe the bug:
Unlink from library / Save to library actions do not work for maximized panels

Steps to reproduce:

  1. create / open dashboard
  2. maximize some panel
  3. Try to do Unlink from library / Save to library action

Expected behavior:
Action should be executed, updated panel should be on the dashboard

Screenshots (if relevant):

Screen.Recording.2022-09-01.at.15.50.54.mov

Errors in browser console (if relevant):
No related errors in console
image
@alexwizp alexwizp added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Ah yes, this makes sense - when you link or unlink the embeddable ID changes, and the maximized panel is based on the embeddable ID. We will probably just need to add a line that resets the maximized panel back to undefined when any action is taken that would change the embeddable ID.

@ThomThomson ThomThomson added good first issue low hanging fruit loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:Dashboard Dashboard related features labels Sep 1, 2022
@kibanamachine kibanamachine added this to Inbox in Dashboard Sep 1, 2022
@ThomThomson ThomThomson changed the title [Dashboard] Unlink from library / Save to library actions do not work for maximized panels [Dashboard] Library Actions Break Maximized Panel View Nov 3, 2022
@ThomThomson ThomThomson added the Project:Dashboard Usability Related to the Dashboard Usability initiative label Nov 3, 2022
@exalate-issue-sync exalate-issue-sync bot changed the title [Dashboard] Library Actions Break Maximized Panel View [Dashboard] Unlink from library / Save to library actions do not work for maximized panels Nov 4, 2022
@cqliu1 cqliu1 mentioned this issue Nov 7, 2022
Closed
22 tasks
@cqliu1 cqliu1 mentioned this issue Jan 18, 2023
Open
18 tasks
dmprieto added a commit to dmprieto/kibana that referenced this issue Feb 3, 2023
@dmprieto
[Dashboard] Unlink from library / Save to library actions do not work…
032ab0a 
… for maximized panels elastic#139915

- As stated in the issue comments, after linking/unlinking to the library, the expanded panel id is reset to undefined
@ThomThomson
Copy link
Contributor

@dmprieto, if you open a PR against the main branch of elastic/kibana we can likely merge your fix!

@dmprieto dmprieto mentioned this issue Feb 6, 2023
Merged
@ThomThomson ThomThomson removed this from Inbox in Dashboard Feb 6, 2023
cqliu1 pushed a commit that referenced this issue Feb 7, 2023
@dmprieto
[Dashboard] Unlink from library / Save to library actions do not work… (
c71725e 
#150338)

… for maximized panels #139915

## Summary
As suggested in the issue comments
#139915 (comment),
in this PR I added some logic after linking/unlinking to the library to
set the expanded visualization id to undefined.

After testing this changes in a local development environment, the
visualization is no longer disappearing from the dashboard after
linking/unlinking to the library
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Feb 7, 2023
@dmprieto @cqliu1
[Dashboard] Unlink from library / Save to library actions do not work…
15d53d2 
… for maximized panels elastic#139915

- As stated in the issue comments, after linking/unlinking to the library, the expanded panel id is reset to undefined
darnautov pushed a commit to darnautov/kibana that referenced this issue Feb 7, 2023
@dmprieto @darnautov
[Dashboard] Unlink from library / Save to library actions do not work… (
91310a8 
elastic#150338)

… for maximized panels elastic#139915

## Summary
As suggested in the issue comments
elastic#139915 (comment),
in this PR I added some logic after linking/unlinking to the library to
set the expanded visualization id to undefined.

After testing this changes in a local development environment, the
visualization is no longer disappearing from the dashboard after
linking/unlinking to the library
This was referenced Feb 7, 2023
Merged
Merged
@cqliu1
Copy link
Contributor

cqliu1 commented Feb 7, 2023

Closed with #150338.

benakansara pushed a commit to benakansara/kibana that referenced this issue Feb 7, 2023
@dmprieto @benakansara
[Dashboard] Unlink from library / Save to library actions do not work… (
e8e2d8a 
elastic#150338)

… for maximized panels elastic#139915

## Summary
As suggested in the issue comments
elastic#139915 (comment),
in this PR I added some logic after linking/unlinking to the library to
set the expanded visualization id to undefined.

After testing this changes in a local development environment, the
visualization is no longer disappearing from the dashboard after
linking/unlinking to the library
@cqliu1 cqliu1 self-assigned this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] Fix Unlink from Library / Save to Library for Maximized Panel dmprieto/kibana
4 participants
@cqliu1 @ThomThomson @elasticmachine @alexwizp