Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FTR command line options for 7.17 #142646

Closed
liza-mae opened this issue Oct 4, 2022 · 4 comments
Closed

Fix FTR command line options for 7.17 #142646

liza-mae opened this issue Oct 4, 2022 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Oct 4, 2022

There appears to be a bug on 7.17 branch for the following FTR options: --include and --exclude, see below:

On main:

    --include=file     a test file to be included, pass multiple times for multiple files
    --exclude=file     a test file to be excluded, pass multiple times for multiple files
    --include-tag=tag  a tag to be included, pass multiple times for multiple tags. Only
                         suites which have one of the passed include-tag tags will be executed.
                         When combined with the --exclude-tag flag both conditions must be met
                         for a suite to run.
    --exclude-tag=tag  a tag to be excluded, pass multiple times for multiple tags. Any suite
                         which has any of the exclude-tags will be excluded. When combined with
                         the --include-tag flag both conditions must be met for a suite to run.

On 7.17:

    --include-tag=tag  a tag to be included, pass multiple times for multiple tags. Only
                         suites which have one of the passed include-tag tags will be executed.
                         When combined with the --exclude-tag flag both conditions must be met
                         for a suite to run.
    --exclude-tag=tag  a tag to be excluded, pass multiple times for multiple tags. Any suite
                         which has any of the exclude-tags will be excluded. When combined with
                         the --include-tag flag both conditions must be met for a suite to run.
    --include-tag=tag  a tag to be included, pass multiple times for multiple tags
    --exclude-tag=tag  a tag to be excluded, pass multiple times for multiple tags

Although despite the help message, I pass in --exclude tag on 7.17 but it does not work.

Can we fix 7.17 for the --include and --exclude options?

cc: @spalger

@liza-mae liza-mae added the Team:Operations Team label for Operations Team label Oct 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@liza-mae liza-mae added the bug Fixes for quality problems that affect the customer experience label Oct 4, 2022
@liza-mae
Copy link
Contributor Author

When can this be looked at?

@liza-mae
Copy link
Contributor Author

Turns out this was an issue with the paths when running inside x-pack directory versus outside, the functionality appears to work, just the help message needs updating.

@Ikuni17 Ikuni17 self-assigned this May 5, 2023
Ikuni17 added a commit that referenced this issue May 9, 2023
## Summary

Fixes #142646 to align FTR CLI include and exclude flag help text with
`8.x`. The original fix in #86971 had a bad backport into `7.x` in PR
#86976.
@Ikuni17
Copy link
Contributor

Ikuni17 commented May 9, 2023

Fixed by #157207

@Ikuni17 Ikuni17 closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants