Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] Fix FTR CLI include and exclude flag help text #157207

Merged
merged 1 commit into from
May 9, 2023
Merged

[7.17] Fix FTR CLI include and exclude flag help text #157207

merged 1 commit into from
May 9, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented May 9, 2023 •
edited
Loading

Summary

Fixes #142646 to align FTR CLI include and exclude flag help text with 8.x. The original fix in #86971 had a bad backport into 7.x in PR #86976.

@Ikuni17 Ikuni17 requested a review from a team May 9, 2023 19:11
@Ikuni17 Ikuni17 self-assigned this May 9, 2023
@Ikuni17 Ikuni17 changed the title Revert bad backport for include and exclude flags [7.17] Fix FTR CLI include and exclude help text May 9, 2023
@Ikuni17 Ikuni17 changed the title [7.17] Fix FTR CLI include and exclude help text [7.17] Fix FTR CLI include and exclude flag help text May 9, 2023
@Ikuni17 Ikuni17 added backport:skip This commit does not require backporting Team:Operations Team label for Operations Team v7.17.11 labels May 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Congrats on your first PR 🎉

@mistic mistic added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels May 9, 2023
@Ikuni17 Ikuni17 enabled auto-merge (squash) May 9, 2023 19:32
@Ikuni17 Ikuni17 merged commit 068dfe5 into elastic:7.17 May 9, 2023
5 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17 Ikuni17 deleted the fix/142646/ftr-cli-options-717 branch May 9, 2023 21:57
@Ikuni17 Ikuni17 mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

Assignees

@Ikuni17 Ikuni17

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ikuni17 @elasticmachine @kibana-ci @mistic