Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable observability] Alerts page - Fix page goes blank with invalid query input #143641

Closed
Tracked by #134886
maryam-saeidi opened this issue Oct 19, 2022 · 1 comment · Fixed by #145259
Closed
Tracked by #134886

[Actionable observability] Alerts page - Fix page goes blank with invalid query input #143641

maryam-saeidi opened this issue Oct 19, 2022 · 1 comment · Fixed by #145259
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Oct 19, 2022 •
edited
Loading

📝 Summary

When an invalid input such as { is entered in query input, it will cause the page to goes into blank:

Screen-Recording-2022-10-19-at-1.51.15-PM.mp4

Another query to reproduce the error, suggested by @CoenWarmer here:

host.cpu.usage >= "25%"""

✅ Acceptance Criteria

  • Fix the above-mentioned issue by making sure the input in the search bar is valid before attempting to get the related alerts from ES.

💡Implementation hint

@Kerry350 already found a way to fix this issue for the logs' search bar, this fix can be found in this PR
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 labels Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi changed the title [Actionable observability] Fix alerts page goes blank with invalid query input [Actionable observability] Alerts page - Fix page goes blank with invalid query input Oct 19, 2022
This was referenced Nov 9, 2022
Merged
Closed
@maryam-saeidi maryam-saeidi self-assigned this Nov 13, 2022
@maryam-saeidi maryam-saeidi mentioned this issue Nov 13, 2022
Merged
maryam-saeidi added a commit that referenced this issue Nov 14, 2022
@maryam-saeidi @kibanamachine
[Actionable Observability] Fix alerts' blank page in case of invalid …
2d5709f 
…query string (#145067)

Implements #143641

## 📝 Summary
Fixes the alerts page crash when a wrong query is entered in the search
bar query string.


![image](https://user-images.githubusercontent.com/12370520/201547177-b9d78bfe-545c-455a-b120-3455f8196607.png)

**Note**
I am working on tests but I will create a separate PR for that.

## 🧪 How to test
- Go to alerts / rule details page
- Enter an invalid query such as `{`, page should not crash and you
should see a toast with a related error message

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@maryam-saeidi maryam-saeidi mentioned this issue Nov 15, 2022
Merged
1 task
maryam-saeidi added a commit that referenced this issue Nov 16, 2022
@maryam-saeidi
[Actionable observability] Add tests for alert search bar (#145259)
1566897 
Closes #143641

## Summary

As a follow-up to this PR #145067,
in this PR I've added tests to make sure the same issue will not happen
in the future.

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
benakansara pushed a commit to benakansara/kibana that referenced this issue Nov 17, 2022
@maryam-saeidi @benakansara
[Actionable observability] Add tests for alert search bar (elastic#14…
bd3a6a6 
…5259)

Closes elastic#143641

## Summary

As a follow-up to this PR elastic#145067,
in this PR I've added tests to make sure the same issue will not happen
in the future.

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Actionable observability] Add tests for alert search bar maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine