-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actionable Observability] Integrate alert search bar on rule details page #144718
[Actionable Observability] Integrate alert search bar on rule details page #144718
Conversation
…-rule-details-page
|
||
import { toQuery, fromQuery } from './url'; | ||
|
||
describe('toQuery', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 Successfully copy pasted from APM 😂
@@ -36,15 +34,6 @@ export interface FetchRuleSummaryProps { | |||
ruleId: string; | |||
http: HttpSetup; | |||
} | |||
export interface FetchRuleActionConnectorsProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 Some of the types are duplicated and unused, so I removed them.
…ion with container
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
1 similar comment
@CoenWarmer Nice catch! Unfortunately, this is an issue that we also have on the Alerts page and I've created a ticket for it previously (#143641) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Hey @maryam-saeidi, code looks excellent. I am a little concerned that if this gets merged before the issue in TriggersActionsUI is fixed, end-users could have a sub par experience. So I am going to approve, but I will leave it to your best judgement whether or not it is good to merge for 8.6.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it works as expected and I like the fast autocompletion which not only for the field name but also its value!! 👏🏻
@maryam-saeidi, I found something confusing (we have discussed this topic previously) when we set kibana.alert.status : "active"
in the search bar and then we apply the UI filter but with different value e.g recovered
, the table will show the active
alert while in the UI filter says recovered
i.e. the search override the UI filter
This could not be a big issue if the query in the search bar is simple, the user will figure it out. But if the user have many conditions in the search bar it could be misleading.
I would suggest once the user click on one of the UI filter, we remove any condition mentioned for kibana.alert.status
in the search bar.
Thanks @CoenWarmer and @fkanout for reviewing. 💖 @CoenWarmer Since this is an issue that already exists on the alerts page for a couple of versions, so, unfortunately, it already can cause issues on the alerts page which is IMO more important than the Rule Details page. For the related bug ticket, I think we should be able to fix it after the feature freeze and backport it. @fkanout Indeed we discussed this case, I am not sure how often this issue might happen but if it is challenging for our users, |
* main: [Lens] Rearrange options (elastic#144891) [Actionable Observability] Integrate alert search bar on rule details page (elastic#144718) [Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view (elastic#144575) [Actionable Observability] Add context.alertDetailsUrl to connector template for Uptime > Monitor status & Uptime TLS rules (elastic#144740) [Security Solution] [Feat] Add Bulk Events to Timeline. (elastic#142737) [TIP] Env specific cypress config (elastic#144894) skip flaky suite (elastic#144885) [Enterprise Search] Fixes Search Index page to go blank when connection lost (elastic#144022) [Cloud Posture] track findings pages (elastic#144822) [ContentManagement] Inspector flyout (elastic#144240) [Cloud Posture] Dashboard Redesign - data counter cards (elastic#144565) [TIP] Run e2e pipeline on CI (elastic#144776) [Guided onboarding] Config updates for the Security guide (elastic#144844) Cleanup unused code for claiming tasks by id (elastic#144408) Ping the response-ops team whenever a new connector type is registered (elastic#144736)
Resolves #143962
📝 Summary
In this PR, an alerts search bar was added to the rule details page by syncing its state to the URL. This will enable navigating to the alerts table for a specific rule with a filtered state based on active or recovered.
Notes
🎨 Preview
🧪 How to test