Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Blank value entry showing under Exception modal field cell #145540

Closed
ghost opened this issue Nov 17, 2022 · 12 comments
Closed

[Security Solution] Blank value entry showing under Exception modal field cell #145540

ghost opened this issue Nov 17, 2022 · 12 comments
Assignees
@yctercero
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0

Comments

@ghost
Copy link

ghost commented Nov 17, 2022

Describe the bug
Blank value entry showing under Exception modal field cell

Build Details:

Version:8.6.0 BC1
Commit:50a7feb0a5eb068d3acccc49c83b9ccb6db6734f
Build:58392

Steps

  • Go to Rule Exceptions page from Manage group of Security App
  • Expand the card
  • Click on Create Rule Exception button
  • Under conditions section, click on field cell and scroll down to bottom
  • Observed that blank value selected is showing which is incorrect

Expected

  • No blank value selection should be shown under field cell

Screen-Shot:

image
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the v8.6.0 label Nov 17, 2022
@ghost
Copy link
Author

ghost commented Nov 17, 2022

@karanbirsingh-qasource Please review

@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team labels Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@peluja1012 peluja1012 added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Rule Exceptions Security Solution Rule Exceptions feature and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. triage_needed labels Nov 17, 2022
@dhurley14
Copy link
Contributor

I will double check this but I'm wondering if this was added to support a custom field entry.. hmm. Will update if I find something.

@yctercero yctercero self-assigned this Feb 16, 2023
@yctercero yctercero mentioned this issue Feb 16, 2023
Merged
8 tasks
@yctercero
Copy link
Contributor

PR with fix - #151398

yctercero added a commit that referenced this issue Feb 23, 2023
@yctercero
[Security Solution][Exceptions] - Fix empty combo box entry option fo…
28f4f1b 
…r exception item condition (#151398)

## Summary

Addresses #145540

Filters out the empty default entry item from combo box option.
kibanamachine pushed a commit that referenced this issue Feb 23, 2023
@yctercero
[Security Solution][Exceptions] - Fix empty combo box entry option fo…
264ad66 
…r exception item condition (#151398)

## Summary

Addresses #145540

Filters out the empty default entry item from combo box option.

(cherry picked from commit 28f4f1b)
kibanamachine added a commit that referenced this issue Feb 23, 2023
@kibanamachine @yctercero
[8.7] [Security Solution][Exceptions] - Fix empty combo box entry opt…
5573b3a 
…ion for exception item condition (#151398) (#151959)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Exceptions] - Fix empty combo box entry option
for exception item condition
(#151398)](#151398)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-23T02:10:38Z","message":"[Security
Solution][Exceptions] - Fix empty combo box entry option for exception
item condition (#151398)\n\n## Summary\r\n\r\nAddresses
#145540 out the
empty default entry item from combo box
option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","auto-backport","Team:Security
Solution
Platform","backport:prev-minor","v8.7.0","v8.8.0"],"number":151398,"url":"#151398
Solution][Exceptions] - Fix empty combo box entry option for exception
item condition (#151398)\n\n## Summary\r\n\r\nAddresses
#145540 out the
empty default entry item from combo box
option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151398
Solution][Exceptions] - Fix empty combo box entry option for exception
item condition (#151398)\n\n## Summary\r\n\r\nAddresses
#145540 out the
empty default entry item from combo box
option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90"}}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
@yctercero
Copy link
Contributor

Available in 8.7 BC4

@MadameSheema
Copy link
Member

@karanbirsingh-qasource @sukhwindersingh-qasource can you please validate this issue on the current BC? Thanks!!

@sukhwindersingh-qasource
Copy link

Hi @MadameSheema
we have validated this issue on 8.7.0 BC4 and found this issue to be still occuring ❌

Please find the below Testing Details:

Build info

VERSION: 8.7.0
BUILD: 60949
COMMIT: de22cd9361a0dbf429f9648d3c7b7c45aa862e90

Screen-Recording

Shared.Exception.Lists.-.Kibana.Mozilla.Firefox.2023-03-09.11-30-19.mp4

Please let us know if anything else is required from our end!!
Thanks!!

@sukhwindersingh-qasource
Copy link

Hi @MadameSheema

We have validated this issue on 8.7.0 BC9 build and observed that issue looks like , It is still occurring ❌

Please find the below Testing Details:

Build info

VERSION: 8.7.0 BC9
BUILD: 61093
COMMIT: 8eda067283f541c673beb406ae5480da6dab9296

Screen-Recording

Alerts.-.Kibana.Mozilla.Firefox.2023-03-24.12-21-04.mp4

Please let us know if anything else is required from our end!!
Thanks!!

@MadameSheema
Copy link
Member

@yctercero can you please take a look at this? I'm going to remove the fixed label for now.

@yctercero yctercero mentioned this issue Apr 19, 2023
Merged
8 tasks
yctercero added a commit that referenced this issue Apr 20, 2023
@yctercero
[Security Solution][Exceptions] - Fix empty selection showing for exc…
afced9d 
…eption item field selection (#155221)

## Summary

Addresses #145540

- blank space no longer shows as selection option for exception item
field dropdown
nikitaindik pushed a commit to nikitaindik/kibana that referenced this issue Apr 25, 2023
@yctercero @nikitaindik
[Security Solution][Exceptions] - Fix empty selection showing for exc…
e96503d 
…eption item field selection (elastic#155221)

## Summary

Addresses elastic#145540

- blank space no longer shows as selection option for exception item
field dropdown
@MadameSheema
Copy link
Member

@sukhwindersingh-qasource validate this issue on current BC. Thanks

@sukhwindersingh-qasource
Copy link

Hi @MadameSheema

We have validated this issue on 8.8.0 BC2 build and observed that issue looks like , It is Fixed. ✔️

Please find the below Testing Details:

Build info

VERSION: 8.8.0 BC2
BUILD: 62857
COMMIT: 33efd47ee6927b54b328e901fe31d31eae875325

Screen-Recording

Alerts.-.Kibana.Mozilla.Firefox.2023-05-05.10-52-15.mp4

Hence We are closing this ticket and marking it as QA Validated
Thanks!!

@sukhwindersingh-qasource sukhwindersingh-qasource added the QA:Validated Issue has been validated by QA label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yctercero yctercero

Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@peluja1012 @dhurley14 @yctercero @elasticmachine @MadameSheema @sukhwindersingh-qasource