[Security Solution][Exceptions] - Fix empty combo box entry option for exception item condition #151398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
bug
nkhristinin
approved these changes
Feb 20, 2023
WafaaNasr
reviewed
Feb 21, 2023
| @@ -32,7 +32,7 @@ const getExistingFields = (indexPattern: DataViewBase | undefined): DataViewFiel | |||
| }; | |||
|
|
|||
| const getSelectedFields = (selectedField: DataViewField | undefined): DataViewFieldBase[] => { | |||
| return selectedField ? [selectedField] : []; | |||
| return selectedField && selectedField.name.trim() !== '' ? [selectedField] : []; | |||
There was a problem hiding this comment.
Nit: can't we use the paramContainsSpace for checking the electedField && selectedField.name.trim() !== '' so that we can unify the condition in different places ?
WafaaNasr
approved these changes
Feb 21, 2023
yctercero
added
v8.8.0
auto-backport
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Feb 23, 2023
…ion for exception item condition (#151398) (#151959) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution][Exceptions] - Fix empty combo box entry option for exception item condition (#151398)](#151398) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-23T02:10:38Z","message":"[Security Solution][Exceptions] - Fix empty combo box entry option for exception item condition (#151398)\n\n## Summary\r\n\r\nAddresses #145540 out the empty default entry item from combo box option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","auto-backport","Team:Security Solution Platform","backport:prev-minor","v8.7.0","v8.8.0"],"number":151398,"url":"#151398 Solution][Exceptions] - Fix empty combo box entry option for exception item condition (#151398)\n\n## Summary\r\n\r\nAddresses #145540 out the empty default entry item from combo box option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151398 Solution][Exceptions] - Fix empty combo box entry option for exception item condition (#151398)\n\n## Summary\r\n\r\nAddresses #145540 out the empty default entry item from combo box option.","sha":"28f4f1b457e5e15100b51b26f76d7c13bad3dc90"}}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #145540
Filters out the empty default entry item from combo box option.
Checklist