New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]Full Screen of Rule Preview breaking the UI under Rule Creation form #145954
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@deepikakeshav-qasource please review |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
… Rule Creation form (elastic#145954)
… Rule Creation form (#146687) ## Summary These changes fix broken fullscreen table that displays the rule preview results. Fullscreen table before fix: <img width="1879" alt="Screenshot 2022-11-30 at 14 46 00" src="https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png"> Fullscreen table after fix: <img width="1881" alt="Screenshot 2022-11-30 at 14 45 20" src="https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png"> Ticket: #145954 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
… Rule Creation form (elastic#146687) ## Summary These changes fix broken fullscreen table that displays the rule preview results. Fullscreen table before fix: <img width="1879" alt="Screenshot 2022-11-30 at 14 46 00" src="https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png"> Fullscreen table after fix: <img width="1881" alt="Screenshot 2022-11-30 at 14 45 20" src="https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png"> Ticket: elastic#145954 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d9b690f)
… under Rule Creation form (#146687) (#146736) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form (#146687)](#146687) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2022-11-30T17:57:30Z","message":"[Security Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken fullscreen table that displays the rule preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46 00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30 at 14 45 20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket: #145954\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Alerts","backport:prev-minor","ci:cloud-deploy","v8.7.0"],"number":146687,"url":"#146687 Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken fullscreen table that displays the rule preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46 00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30 at 14 45 20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket: #145954\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#146687 Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken fullscreen table that displays the rule preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46 00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30 at 14 45 20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket: #145954\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
@MadameSheema @karanbirsingh-qasource This bug was fixed and changes were merged in both Ian and 8.6 branches. |
Hi @e40pud we have validated this issue on 8.6 branch and found the issue to be fixed now ✔️ . Build Details:
Screen-Cast KaranV_Linux.Master.VM2.-.VMware.Remote.Console.2022-12-01.22-37-57.mp4we are keeping it open until we will check this issue on 8.6 BC5 (as issue is still occuring on BC4) c.c @MadameSheema |
we have validated this issue on 8.6 BC5 and found the issue fixed ✔️ . Build Details:
Screen-Cast: Create.new.rule.-.Kibana.Mozilla.Firefox.2022-12-05.13-01-18.mp4Hence we are closing this issue and adding "QA:Validated" tag to it. thanks !! |
Describe the bug
Full Screen of Rule Preview breaking the UI under Rule Creation form
Build Details:
Steps
Expected Result
Screen-Cast:
Create.new.rule.-.Kibana.Mozilla.Firefox.2022-11-21.15-08-49.mp4
The text was updated successfully, but these errors were encountered: