Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Full Screen of Rule Preview breaking the UI under Rule Creation form #145954

Closed
karanbirsingh-qasource opened this issue Nov 22, 2022 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@karanbirsingh-qasource
Copy link

Describe the bug
Full Screen of Rule Preview breaking the UI under Rule Creation form

Build Details:

Version:8.6.0 BC1
Commit:50a7feb0a5eb068d3acccc49c83b9ccb6db6734f
Build:58392

Steps

  • Login to Kibana
  • Go to Rule Page and Click on Create Rule
  • Fill in the required details of Rule Creation
  • Click on the Rule Preview
  • Select the appropriate time filter and click on full screen
  • Observed that event list under preview does not show properly and breaks the UI

Expected Result

  • UI should not break on full screen on the Rule creation of Rule Preview

Screen-Cast:

Create.new.rule.-.Kibana.Mozilla.Firefox.2022-11-21.15-08-49.mp4

image

@karanbirsingh-qasource karanbirsingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@karanbirsingh-qasource karanbirsingh-qasource added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Nov 22, 2022
@karanbirsingh-qasource
Copy link
Author

@deepikakeshav-qasource please review

@ghost ghost added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 22, 2022
@ghost ghost assigned MadameSheema and unassigned ghost Nov 22, 2022
@ghost ghost added the v8.6.0 label Nov 22, 2022
@MadameSheema MadameSheema added Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team labels Nov 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@marshallmain marshallmain assigned e40pud and unassigned marshallmain Nov 28, 2022
e40pud added a commit to e40pud/kibana that referenced this issue Nov 30, 2022
e40pud added a commit that referenced this issue Nov 30, 2022
… Rule Creation form (#146687)

## Summary

These changes fix broken fullscreen table that displays the rule preview
results.

Fullscreen table before fix:

<img width="1879" alt="Screenshot 2022-11-30 at 14 46 00"
src="https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png">

Fullscreen table after fix:

<img width="1881" alt="Screenshot 2022-11-30 at 14 45 20"
src="https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png">

Ticket: #145954

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 30, 2022
… Rule Creation form (elastic#146687)

## Summary

These changes fix broken fullscreen table that displays the rule preview
results.

Fullscreen table before fix:

<img width="1879" alt="Screenshot 2022-11-30 at 14 46 00"
src="https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png">

Fullscreen table after fix:

<img width="1881" alt="Screenshot 2022-11-30 at 14 45 20"
src="https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png">

Ticket: elastic#145954

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d9b690f)
kibanamachine added a commit that referenced this issue Nov 30, 2022
… under Rule Creation form (#146687) (#146736)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Full Screen of Rule Preview breaking the UI under
Rule Creation form
(#146687)](#146687)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2022-11-30T17:57:30Z","message":"[Security
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Alerts","backport:prev-minor","ci:cloud-deploy","v8.7.0"],"number":146687,"url":"#146687
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#146687
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
@e40pud e40pud added the fixed label Nov 30, 2022
@e40pud
Copy link
Contributor

e40pud commented Nov 30, 2022

@MadameSheema @karanbirsingh-qasource This bug was fixed and changes were merged in both Ian and 8.6 branches.

@karanbirsingh-qasource
Copy link
Author

Hi @e40pud

we have validated this issue on 8.6 branch and found the issue to be fixed now ✔️ .

Build Details:

Version: 8.6.0 BC4
Commit: 218162f282314db5b3833c84752dd24395949b3f
Build: 58612

Screen-Cast

KaranV_Linux.Master.VM2.-.VMware.Remote.Console.2022-12-01.22-37-57.mp4

we are keeping it open until we will check this issue on 8.6 BC5 (as issue is still occuring on BC4)

c.c @MadameSheema

@karanbirsingh-qasource
Copy link
Author

Hi @MadameSheema

we have validated this issue on 8.6 BC5 and found the issue fixed ✔️ .

Build Details:

Version: 8.6.0 BC5
Commit:ed40c16ce9999cc47ad55c11bb097d2e443b31a6
Build:58693

Screen-Cast:

Create.new.rule.-.Kibana.Mozilla.Firefox.2022-12-05.13-01-18.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost added the QA:Validated Issue has been validated by QA label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Development

No branches or pull requests

5 participants