Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form #146687

Merged
merged 2 commits into from Nov 30, 2022
Merged

[Security Solution] Full Screen of Rule Preview breaking the UI under Rule Creation form #146687

merged 2 commits into from Nov 30, 2022

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 30, 2022 •
edited by kibanamachine

Summary

These changes fix broken fullscreen table that displays the rule preview results.

Fullscreen table before fix:

Screenshot 2022-11-30 at 14 46 00

Fullscreen table after fix:

Screenshot 2022-11-30 at 14 45 20

Ticket: #145954

@e40pud e40pud added release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment labels Nov 30, 2022
@e40pud e40pud requested a review from a team as a code owner November 30, 2022 13:48
@e40pud e40pud self-assigned this Nov 30, 2022
@e40pud e40pud requested a review from spong November 30, 2022 13:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@e40pud
Copy link
Contributor Author

e40pud commented Nov 30, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 30, 2022 •
edited

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.6MB 9.6MB +103.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

spong
spong approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@spong spong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified issue beforehand, then checked out and tested fix and the Rule Preview table now goes into full screen mode without issue -- LGTM! 🎉

Note, in testing I found these two other UI issues. Not sure if they're currently tracked, but wanted to make note:

  1. Due to the smaller fixed width of the split pane, the Inspect hover button covers up the Keyboard Shortcuts button, making it quite difficult to click:

  1. Re-sizing the window past a certain min-width results in the Rule Preview table disappearing until Refresh is clicked:

@e40pud e40pud merged commit d9b690f into elastic:main Nov 30, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 30, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2022
@e40pud
[Security Solution] Full Screen of Rule Preview breaking the UI under…
b8e0d76 
… Rule Creation form (elastic#146687)

## Summary

These changes fix broken fullscreen table that displays the rule preview
results.

Fullscreen table before fix:

<img width="1879" alt="Screenshot 2022-11-30 at 14 46 00"
src="https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png">

Fullscreen table after fix:

<img width="1881" alt="Screenshot 2022-11-30 at 14 45 20"
src="https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png">

Ticket: elastic#145954

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d9b690f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 30, 2022
@kibanamachine @e40pud
[8.6] [Security Solution] Full Screen of Rule Preview breaking the UI…
582fed3 
… under Rule Creation form (#146687) (#146736)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Full Screen of Rule Preview breaking the UI under
Rule Creation form
(#146687)](#146687)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2022-11-30T17:57:30Z","message":"[Security
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Alerts","backport:prev-minor","ci:cloud-deploy","v8.7.0"],"number":146687,"url":"#146687
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#146687
Solution] Full Screen of Rule Preview breaking the UI under Rule
Creation form (#146687)\n\n## Summary\r\n\r\nThese changes fix broken
fullscreen table that displays the rule
preview\r\nresults.\r\n\r\nFullscreen table before fix:\r\n\r\n<img
width=\"1879\" alt=\"Screenshot 2022-11-30 at 14 46
00\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812399-52138490-a42a-4ea2-bd00-04680375580a.png\">\r\n\r\nFullscreen
table after fix:\r\n\r\n<img width=\"1881\" alt=\"Screenshot 2022-11-30
at 14 45
20\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/204812419-5b528ae5-02e4-4808-adcc-14ede7cec56b.png\">\r\n\r\nTicket:
#145954\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d9b690f97a450fa29ea602e8181861045242c35f"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
@e40pud
Copy link
Contributor Author

e40pud commented Dec 1, 2022

Thanks @spong we've seen second issue, but not the first one. I will make a note of those and will address them in one of the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@e40pud @elasticmachine @kibana-ci @kibanamachine @spong