Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User shouldn't(?) be allowed to create a saved search on Kibana when there is a single adhoc-dataview and no other dataviews #150317

Closed
bhavyarm opened this issue Feb 6, 2023 · 5 comments · Fixed by #160747
Assignees
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Feb 6, 2023

Kibana version: 8.7.0 snapshot

Elasticsearch version: 8.7.0 snapshot

Server OS version: darwin

Browser version: chrome latest

Browser OS version: OS X

Describe the bug: User is allowed to create a saved search on a single adhoc dataview in discover. They cannot access this saved search after except from saved objects management table.

Steps to reproduce:

  1. Make sure you have data in es but no dataviews in Kibana
  2. Go to discover and create an ad-hoc dataview
  3. save a search on it
  4. search gets saved and Kibana gives you create dataview screen again

I am not sure what should be the expected behaviour here should be? Should we warn the user? Ban the creation of saved search?

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Feb 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover Feb 6, 2023
@lukasolson
Copy link
Member

Hmm... How are you able to get to Discover in the first place when you have no data views? I always get this view:

Screen Shot 2023-02-06 at 10 37 48 AM

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Feb 6, 2023

Go to discover - you get this screen -> click on create data-view->click on create dataview without saving(adhoc)->
Screen Shot 2023-02-06 at 11 33 07 PM

@lukasolson
Copy link
Member

Hmm, a couple of comments on this one:

It looks like Visualize and Dashboard both hide the "Use without saving" dialog in the case that there are no other data views. Discover doesn't. It should probably function the same as the others.

If you create a data view, then create a dashboard using an adhoc data view, then delete the saved data view, you can get into this same situation.

It seems to me like we should bypass the data view page when opening any saved object associated with an ad-hoc data view.

@davismcphee davismcphee added loe:needs-research This issue requires some research before it can be worked on or estimated impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 7, 2023
@kertal
Copy link
Member

kertal commented May 30, 2023

It looks like Visualize and Dashboard both hide the "Use without saving" dialog in the case that there are no other data views. Discover doesn't. It should probably function the same as the others.
Yes, let's align this behavior

@jughosta jughosta self-assigned this Jun 28, 2023
jughosta added a commit that referenced this issue Jun 30, 2023
- Closes #150317

## Summary

This PR:
- hides "Use without saving" button from NoData screen on Discover page
to align with Dashboard and Lens behaviour
- allows to open a saved search via URL even if there are no data views
present (before NoData screen was shown instead).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants