Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Adjust NoData screen #160747

Merged
merged 6 commits into from Jun 30, 2023
Merged

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jun 28, 2023

Summary

This PR:

  • hides "Use without saving" button from NoData screen on Discover page to align with Dashboard and Lens behaviour
  • allows to open a saved search via URL even if there are no data views present (before NoData screen was shown instead).

@jughosta jughosta added Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jun 28, 2023
@jughosta jughosta self-assigned this Jun 28, 2023
@jughosta jughosta marked this pull request as ready for review June 28, 2023 17:57
@jughosta jughosta requested a review from a team as a code owner June 28, 2023 17:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 529.8KB 529.9KB +49.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@kertal kertal requested a review from a team June 30, 2023 06:43
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thx for fixing this 🙏 . Tested locally and works like expected

@jughosta jughosta added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jun 30, 2023
@jughosta jughosta merged commit 91fbd8e into elastic:main Jun 30, 2023
23 checks passed
@jughosta jughosta deleted the 150317-ad-hoc-when-empty branch June 30, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.10.0
Projects
None yet
4 participants