Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB not updating with browser time zone changes #15501

Closed
stacey-gammon opened this issue Dec 8, 2017 · 1 comment · Fixed by #15512
Closed

TSVB not updating with browser time zone changes #15501

stacey-gammon opened this issue Dec 8, 2017 · 1 comment · Fixed by #15512
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@stacey-gammon
Copy link
Contributor

It looks like TSVB visualizations aren't updating their data based on timezone changes.

For instance, here is a TSVB and a bar chart in EST time:
screen shot 2017-12-08 at 12 36 25 pm

And here they are after I update management advanced settings to UTC time:
screen shot 2017-12-08 at 12 36 04 pm

You can see the x axis in the bar chart updates so the values match different times. However, the x axis on the TSVB visualization doesn't change at all. I believe this is wrong.

cc @simianhacker cc @elastic/kibana-visualizations
@stacey-gammon stacey-gammon added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Dec 8, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 8, 2017
@stacey-gammon
Stop trying to get TSVB to pass, try area charts
55cd94a 
There is a timezone bug with tsvb:
elastic#15501
simianhacker added a commit to simianhacker/kibana that referenced this issue Dec 8, 2017
@simianhacker
Fixes elastic#15501 - Change xaxis formatter to honor dateFormat:tz; …
1a3f89d 
…fix tick count to accomadate new formatting rules
simianhacker added a commit to simianhacker/kibana that referenced this issue Dec 8, 2017
@simianhacker
Fixes elastic#15501 - Change xaxis formatter to honor dateFormat:tz; …
06023b5 
…fix tick count to accommodate new formatting rules
@simianhacker simianhacker mentioned this issue Dec 8, 2017
Merged
@simianhacker
Copy link
Member

PR #15512 Pending

stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 12, 2017
@stacey-gammon
Stop trying to get TSVB to pass, try area charts
d71c748 
There is a timezone bug with tsvb:
elastic#15501
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 12, 2017
@stacey-gammon
Stop trying to get TSVB to pass, try area charts
1131683 
There is a timezone bug with tsvb:
elastic#15501
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 13, 2017
@stacey-gammon
Stop trying to get TSVB to pass, try area charts
5c71ca8 
There is a timezone bug with tsvb:
elastic#15501
stacey-gammon added a commit that referenced this issue Dec 13, 2017
@stacey-gammon
Add mechanism for dashboard snapshots (#15463)
56b9a7c 
* Add mechanism for dashboard snapshots

* Adjust wait for render function since it needs to be 2, not gt 0.

Should be obsolete when the new render stuff is complete.

* resize images using new library so comparisons work across different screen resolutions

* use jimp comparison and see if expanding to expanded panel mode helps when comparing across browser/os

* Try to ensure window size

* Experiment with a smaller window, see if screenshot dimensions change

Update screenshot for new window dimensions

* Try cover + quality, see what the diffs look like.

* Stop trying to get TSVB to pass, try area charts

There is a timezone bug with tsvb:
#15501

* gah, cover didn't work, check resize

* bump render counter to 6, as it should be.

As it turns out, the visualization was not done re-rendering to
maximized mode

* Bump threshold for comparison

* reduce down to a single test run

* Don't use an environment variable to detect updateBaselines cmd line flag
stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 13, 2017
@stacey-gammon
Add mechanism for dashboard snapshots (elastic#15463)
507ecca 
* Add mechanism for dashboard snapshots

* Adjust wait for render function since it needs to be 2, not gt 0.

Should be obsolete when the new render stuff is complete.

* resize images using new library so comparisons work across different screen resolutions

* use jimp comparison and see if expanding to expanded panel mode helps when comparing across browser/os

* Try to ensure window size

* Experiment with a smaller window, see if screenshot dimensions change

Update screenshot for new window dimensions

* Try cover + quality, see what the diffs look like.

* Stop trying to get TSVB to pass, try area charts

There is a timezone bug with tsvb:
elastic#15501

* gah, cover didn't work, check resize

* bump render counter to 6, as it should be.

As it turns out, the visualization was not done re-rendering to
maximized mode

* Bump threshold for comparison

* reduce down to a single test run

* Don't use an environment variable to detect updateBaselines cmd line flag
stacey-gammon added a commit that referenced this issue Dec 13, 2017
@stacey-gammon
Add mechanism for dashboard snapshots (#15463) (#15593)
faa2e97 
* Add mechanism for dashboard snapshots

* Adjust wait for render function since it needs to be 2, not gt 0.

Should be obsolete when the new render stuff is complete.

* resize images using new library so comparisons work across different screen resolutions

* use jimp comparison and see if expanding to expanded panel mode helps when comparing across browser/os

* Try to ensure window size

* Experiment with a smaller window, see if screenshot dimensions change

Update screenshot for new window dimensions

* Try cover + quality, see what the diffs look like.

* Stop trying to get TSVB to pass, try area charts

There is a timezone bug with tsvb:
#15501

* gah, cover didn't work, check resize

* bump render counter to 6, as it should be.

As it turns out, the visualization was not done re-rendering to
maximized mode

* Bump threshold for comparison

* reduce down to a single test run

* Don't use an environment variable to detect updateBaselines cmd line flag
nyurik pushed a commit to nyurik/kibana that referenced this issue Dec 15, 2017
@stacey-gammon @nyurik
Add mechanism for dashboard snapshots (elastic#15463)
f4a1fe2 
* Add mechanism for dashboard snapshots

* Adjust wait for render function since it needs to be 2, not gt 0.

Should be obsolete when the new render stuff is complete.

* resize images using new library so comparisons work across different screen resolutions

* use jimp comparison and see if expanding to expanded panel mode helps when comparing across browser/os

* Try to ensure window size

* Experiment with a smaller window, see if screenshot dimensions change

Update screenshot for new window dimensions

* Try cover + quality, see what the diffs look like.

* Stop trying to get TSVB to pass, try area charts

There is a timezone bug with tsvb:
elastic#15501

* gah, cover didn't work, check resize

* bump render counter to 6, as it should be.

As it turns out, the visualization was not done re-rendering to
maximized mode

* Bump threshold for comparison

* reduce down to a single test run

* Don't use an environment variable to detect updateBaselines cmd line flag
simianhacker added a commit that referenced this issue Dec 21, 2017
@simianhacker
Fixes #15501 - Change xaxis formatter to honor dateFormat:tz; fix tic…
6c92c10 
…k count to accommodate new formatting rules (#15512)
simianhacker added a commit that referenced this issue Dec 21, 2017
@simianhacker
Fixes #15501 - Change xaxis formatter to honor dateFormat:tz; fix tic…
085dee4 
…k count to accommodate new formatting rules (#15512)
This was referenced May 24, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Fixes #15501 - Change xaxis formatter to honor dateFormat:tz simianhacker/kibana
2 participants
@simianhacker @stacey-gammon