Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time series visual builder vertical lines and times are not consistent when setting time zones #19471

Closed
Tracked by #178
stacey-gammon opened this issue May 28, 2018 · 2 comments · Fixed by #46311
Closed
Tracked by #178

Time series visual builder vertical lines and times are not consistent when setting time zones #19471

stacey-gammon opened this issue May 28, 2018 · 2 comments · Fixed by #46311
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stacey-gammon
Copy link
Contributor

This could present an issue with reporting showing a slightly different chart than what the user sees when they generate it.

screen shot 2018-05-28 at 8 09 30 am

#15501 was fixed but it seems like the time zone setting somehow affects where the vertical lines are placed and also the choosen timestamps on the x-axis.

This breaks snapshot tests for TSVB.
@stacey-gammon stacey-gammon added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:TSVB TSVB (Time Series Visual Builder) labels May 28, 2018
@stacey-gammon stacey-gammon mentioned this issue May 29, 2018
Merged
@LeeDr LeeDr mentioned this issue Jul 17, 2018
Open
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
sulemanof added a commit to sulemanof/kibana that referenced this issue Feb 19, 2019
@sulemanof
Merge remote-tracking branch 'upstream/master' into elastic#19471
435f7e9
@markov00 markov00 mentioned this issue Feb 19, 2019
Closed
19 tasks
sulemanof added a commit to sulemanof/kibana that referenced this issue Feb 21, 2019
@sulemanof
Merge branch 'master' into elastic#19471
15c23a4
@sulemanof sulemanof mentioned this issue Feb 21, 2019
Closed
@sulemanof sulemanof assigned sulemanof and unassigned sulemanof Mar 4, 2019
@alexwizp alexwizp closed this as completed Apr 5, 2019
@markov00 markov00 mentioned this issue Apr 18, 2019
Closed
11 tasks
@LeeDr
Copy link
Contributor

LeeDr commented Sep 20, 2019

There's still a skipped test which references this issue. It hasn't been replaced with a visual test yet.

@LeeDr LeeDr reopened this Sep 20, 2019
@LeeDr
Copy link
Contributor

LeeDr commented Sep 20, 2019

This particular test is here;
https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/dashboard_snapshots.js#L43

But it's inside a describe.skip tracked on this issue;
#40173

@LeeDr LeeDr mentioned this issue Sep 21, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
5 participants
@timroes @LeeDr @stacey-gammon @alexwizp @sulemanof