Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO][SLO Detail] The "View In App" button in the Alert Flyout doesn't do anything #155731

Closed
CoenWarmer opened this issue Apr 25, 2023 · 4 comments · Fixed by #175441
Closed

[SLO][SLO Detail] The "View In App" button in the Alert Flyout doesn't do anything #155731

CoenWarmer opened this issue Apr 25, 2023 · 4 comments · Fixed by #175441
Assignees
@shahzad31
Labels
Feature:Alerting Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.9.0

Comments

@CoenWarmer
Copy link
Contributor

CoenWarmer commented Apr 25, 2023 •
edited
Loading

📝 Summary

When on the SLO Detail page, it has two tabs: Overview and Alerts.

If Alerts are found, the Alerts tab renders the Alerts Table.

When clicking on an Alert, the Alert Flyout appears, with a "View in App" button.

Clicking on it currently does nothing.

✅ Acceptance criteria

  • The AlertFlyout in Observability should have a prop hideViewInAppButton
  • When that's set to true, the View In App Button should be hidden
  • SLO Detail Page > Alerts Tab > Alert > Actions > View Alert > Alert flyout should not have the View in App Button
@CoenWarmer CoenWarmer self-assigned this Apr 25, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 25, 2023
@emma-raffenne emma-raffenne added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 26, 2023
@emma-raffenne
Copy link
Contributor

cc @maciejforcone

@kdelemme
Copy link
Contributor

kdelemme commented May 2, 2023 •
edited
Loading

Some additional context:
We want to keep the view in app link working when the flyout is opened from the alerts page, but we want to hide it from the slo details page.
The flyout is configured when the observability plugin starts, and the alerts table configuration is used for both the alerts page and the slo details page.

We have two possibilities:

  1. Introduce a search query param to select the tab to open the SLO details page on, and use the overview tab for the view in app link. Therefore clicking, the redirection will always work and open the SLO details page on the overview tab.
  2. Duplicate the alerts configuration with one config hiding the "View In App" button, and use that config from the SLO details page's alert tab.

I think this does not need to be fixed for 8.8. Let's see if people clicks on this button from the SLO details page through fullstory and see what they do after.

@kdelemme kdelemme mentioned this issue Jul 4, 2023
Merged
@emma-raffenne emma-raffenne added this to the 8.10 milestone Aug 7, 2023
@emma-raffenne emma-raffenne removed this from the 8.10 milestone Aug 17, 2023
@paulb-elastic paulb-elastic removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 14, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 14, 2023
@paulb-elastic paulb-elastic added the Team:obs-ux-management Observability Management User Experience Team label Nov 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 14, 2023
@shahzad31 shahzad31 self-assigned this Jan 24, 2024
@shahzad31 shahzad31 mentioned this issue Jan 24, 2024
Merged
shahzad31 added a commit that referenced this issue Jan 25, 2024
@shahzad31
[SLOs] Hide view in app in slo alerts table in slo details page (#175441
c5d4ffd 
)

## Summary

Fixes #155731

Since we are already on SLO details page, it doesn't make sense to show
view in app button in flyout or in columns actions.

<img width="1727" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/ddcdf83d-00e0-4579-834b-db4f26e52a2e">
lcawl pushed a commit to lcawl/kibana that referenced this issue Jan 26, 2024
@shahzad31 @lcawl
[SLOs] Hide view in app in slo alerts table in slo details page (elas…
32b5118 
…tic#175441)

## Summary

Fixes elastic#155731

Since we are already on SLO details page, it doesn't make sense to show
view in app button in flyout or in columns actions.

<img width="1727" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/ddcdf83d-00e0-4579-834b-db4f26e52a2e">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@shahzad31 @CoenWarmer
[SLOs] Hide view in app in slo alerts table in slo details page (elas…
3c143a0 
…tic#175441)

## Summary

Fixes elastic#155731

Since we are already on SLO details page, it doesn't make sense to show
view in app button in flyout or in columns actions.

<img width="1727" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/ddcdf83d-00e0-4579-834b-db4f26e52a2e">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@shahzad31 @CoenWarmer
[SLOs] Hide view in app in slo alerts table in slo details page (elas…
26bc6fc 
…tic#175441)

## Summary

Fixes elastic#155731

Since we are already on SLO details page, it doesn't make sense to show
view in app button in flyout or in columns actions.

<img width="1727" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/ddcdf83d-00e0-4579-834b-db4f26e52a2e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
Feature:Alerting Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SLOs] Hide view in app in slo alerts table in slo details page shahzad31/kibana
6 participants
@CoenWarmer @kdelemme @shahzad31 @elasticmachine @paulb-elastic @emma-raffenne