Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie chart scaling in 6.1 results in unusable visualizations. #15594

Closed
robcowart opened this issue Dec 13, 2017 · 17 comments · Fixed by #15641
Closed

Pie chart scaling in 6.1 results in unusable visualizations. #15594

robcowart opened this issue Dec 13, 2017 · 17 comments · Fixed by #15641
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@robcowart
Copy link

robcowart commented Dec 13, 2017

Kibana version: 6.1

Elasticsearch version: 6.1

Server OS version: CentOS 7

Browser version: Chrome

Browser OS version: MacOS High Sierra

Original install method (e.g. download page, yum, from source, etc.): yum

Description of the problem including expected versus actual behavior:
Pie charts which worked well in 6.0.1 and all previous versions no longer scale the same, resulting in previously useful dashboards becoming unusable. This appears to be due to space being reserved for the newly featured labels. However if labels are not enabled, the charts should scale as previously before labels were introduced.

Here is an example of pie charts in 6.0.0, which are rendered as they have been since at least 5.0.

screen shot 2017-12-13 at 20 01 48

Here is the same dashboard in 6.1 at the same window size. The pie charts are now much smaller (even though labels aren't enabled) resulting in an unusable visualization, which impacts the entire dashboard (much more difficult to quickly set filters due to small size of chart).

screen shot 2017-12-13 at 20 02 03

@imweijh
Copy link

imweijh commented Dec 14, 2017

kibana6 1fat
Same problem here with 6.1;
Visualize in dashboard seem fat a lot.

v5.6 and v6.0.1 is ok

@timroes timroes added Feature:Pie Chart Pie chart visualization feature Feature:Vislib Vislib chart implementation Feature:Visualizations Generic visualization features (in case no more specific feature label is available) and removed Feature:Vislib Vislib chart implementation labels Dec 15, 2017
@robcowart
Copy link
Author

robcowart commented Dec 17, 2017

Unfortunately #15641 does not solve this problem (I left my comments there, redirecting back to this issue).

After a closer look, I believe the issue is excessive padding due to the restructuring of the elements which contain the visualization.

Here is 6.0.1...

screen shot 2017-12-17 at 12 14 51

Here is 6.1.0...

screen shot 2017-12-17 at 12 15 05

It is obvious in this comparison how whitespace is wasting screen real estate that was previously being used for rendering data, and is preventing the pie chart from being used as effectively as before. (I will now have to investigate other visualization types as well.)

Using Chrome's Developer Tools this can be easily quantified:

From 6.0.1...

screen shot 2017-12-17 at 12 35 40

From 6.1.0...

screen shot 2017-12-17 at 12 36 05

Alone the panel-heading requires 16 pixels more space in 6.1.0 than in 6.0.1. That is 16 pixels of space that adds no value. If you have three rows of pie charts on a dashboard (e.g. the Logstash Netflow Module), you have added 48 pixels. When considering the space wasted at the bottom as well, the result is nearly a full grid height of wasted screen real estate.

While all of these changes might work well on 3k/4k/5k monitors, it is unwise to assume that users will have more than 1920x1080 to work with (1600x900 is probably a safer bet). Even those of us that use high resolution monitors, most likely have them to get more information on the screen, not to have that extra screen real estate wasted with unnecessary whitespace.

@SnchitGrover
Copy link

+1 Because of a larger legend, the visualisation goes off.

screen shot 2017-12-18 at 1 23 52 pm

@timroes
Copy link
Contributor

timroes commented Dec 18, 2017

This ticket currently mixes up multiple issues.

There is
a) an issue, that pie charts are not taking enough space due to them always saving space for labels (even if they are disabled). This is addressed in #15641
b) due to changes in the dashboard layout we have less space available for visualizations in general. I am also applying the dashboard tag for this, so that we can check and take this into design considerations.
c) @SnchitGrover could you please open a separate issue for that, since legends breaking the chart, is unrelated to these two issues.

@timroes timroes added Feature:Dashboard Dashboard related features :Sharing labels Dec 18, 2017
@robcowart
Copy link
Author

@ppisljar #15641 doesn't completely solve this issue.

@ppisljar
Copy link
Member

ppisljar commented Dec 18, 2017

sorry, seems partly resolves text in the PR is still treated as resolves and auto closes the issue.

@robcowart
Copy link
Author

I have spent some time modifying the styling with good results. In particular...

In KIBANA_HOME/src/core_plugins/kibana/public/dashboard/styles/index.less change these values...

.panel-content {
  padding: 0px 4px;
}
.panel-heading {
  padding: 4px;
}

And in KIBANA_HOME/src/ui/public/visualize/visualize.less

visualization {
  padding: 0px;
}

Results are great for pie charts and have no obvious negative affect on other visualization types as well.
screen shot 2017-12-19 at 17 05 26

screen shot 2017-12-19 at 17 05 45

screen shot 2017-12-19 at 17 06 00

@robcowart
Copy link
Author

I spent even more time on this today as there where actually some worse offenders with excessive padding than my suggestions above. So with these changes you maximize the size for the visualizations, while perserving a little more spacing between visualizations.

KIBANA_HOME/src/ui/public/visualize/visualize.less

visualization {
  padding: 2px;
}

KIBANA_HOME/src/ui/public/vislib/styles/_layout.less

.vis-wrapper {
  padding: 0px;
}

KIBANA_HOME/src/ui/public/vislib/styles/_legend.less

.legend-col-wrapper {
  padding-top: 0px
}

KIBANA_HOME/src/core_plugins/kibana/public/dashboard/styles/index.less

.panel-content {
  padding: 0px 4px 4px 4px;
}
.panel-heading {
  padding: 4px 8px;
}

NOTE: the .panel-content is applied to two divs, one in the other. so the composite result ends up as 0 8px 8px 8px

Here is what out-of-the-box 6.1.1 looks like...

screen shot 2017-12-21 at 14 59 39

And here is the result after the above suggested changes (plus #15641)...

screen shot 2017-12-21 at 15 00 05

The result is much screen real estate used for information as opposed to whitespace, nothing being cutoff (see the markdown visualization at the top), and it still avoids appearing cluttered.

I can create a PR for these changes if desired.

@cskowronnek
Copy link

+1
My donut pie charts look awful in 6.1

@robcowart
Copy link
Author

@cskowronnek if you want to restore some usability until this gets fixed properly, the changes I suggested above are here...

https://github.com/robcowart/kibana_6.1.x_vis_scaling_fixes

This include the both the pie chart w/o labels fix (which did make it into 6.1.2) and the stylesheet changes to reduce padding where it is causing issues. Just replace the current Kibana files with the ones provided in that repo; Delete KIBANA_HOME/optimize/bundles; restart Kibana. Kibana will run a optimization process before starting, which can take a few minutes. This is necessary to pickup the changes.

@ppf2
Copy link
Member

ppf2 commented Feb 14, 2018

Seems like the same issue, we are also seeing shrinking pie charts due to scaling causing them to be unusable with the metricbeats default dashboards. This seems to be exacerbated by the longer docker container/image names (note that container and image names are partially blanked out below on purpose, but you can see what the pie charts look like for these situations).

screen shot 2018-02-14 at 10 46 51 am

@alexfrancoeur alexfrancoeur added the bug Fixes for quality problems that affect the customer experience label Mar 12, 2018
@timroes timroes added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. and removed Feature:Pie Chart Pie chart visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Apr 17, 2018
@t3chn0m4g3
Copy link

I was starting to test drive Kibana 6.2.4 (coming from 5.x) and at first I thought something went wrong with the saved_objectsimport.

Regarding visualizations I am experiencing the exact same problems as @robcowart (thanks for the fix BTW :bowtie:)

I do understand that there is probably more work involved to find a permanent solution, but given the fact that the usefulness of dashboards has drastically declined I would like to know if there is a timeframe / version no. we can expect a solution?

Unfortunately it does not stop with the padding / margins either, even the chosen font has problems with the design changes:
K 6.2.4:
image

K 5.6.5:
image

@robcowart
Copy link
Author

@t3chn0m4g3 more things changed (and unfortunately for the worse) in 6.2. I am attaching my 6.2.x-specific fixes. I haven't tested them in 6.2.4 yet, but they work well in 6.2.0-6.2.3. I have used them both in my environment and at 6 or 7 customer deployments.

kibana_6.2.x_vis_scaling_fixes.zip

@t3chn0m4g3
Copy link

@robcowart Thank you very much! I will apply and test them and give you feedback.

@t3chn0m4g3
Copy link

@robcowart This is so much better!

Before fix:
k624_no_fix

After fix:
k624_with_fix

The only tiny thing I noticed are the cut offs at the Histograms (red arrows). But I would take the fixed version every time over the standard. Could not care less for the (admittedly beautiful) label feature if that reduces the dashboard readability.

Thanks again 👍

@robcowart
Copy link
Author

@t3chn0m4g3 I am glad it works for you. I will take a look at the issue you mentioned. It might be an easy fix.

Thanks for the feedback here. I keep hoping that this issue will get more attention, and perhaps with the additional feedback it will.

@stacey-gammon
Copy link
Contributor

The major issue with pie charts has been fixed, so is it correct to say that all that is remaining is unhappiness with the current increased padding on dashboards?

I recently filed #18582 to switch over to EUI panel components. Kibana as a whole is undergoing some very big UI changes, with an end goal of v7. We will definitely keep this padding feedback in mind as we switch over to EUI panel components and work with the design team to pick an appropriate padding.

Going to close this in favor of that one, but let me know if there is anything I am leaving out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants