Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markdown] remove padding style #16295

Closed
wants to merge 1 commit into from
Closed

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jan 25, 2018

Currently when the markdown visualization is rendered with a single line using the default font size and the smallest dashboard container, a scrollbar appears.

This is commonly used for navigation in beats dashboards:
image

There's double padding between the visualization and markdown containers, so I opted for removing all of the markdown conatainer padding:
image

This isn't reproducible in master because the panel title is 6 pixels smaller, but either way I didn't see a reason to keep both container paddings.

@jbudz jbudz added review Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jan 25, 2018
@jbudz
Copy link
Member Author

jbudz commented Jan 25, 2018

Closes #15986

@timroes
Copy link
Contributor

timroes commented Feb 9, 2018

The padding on the markdown chart has been there since forever. The actual change is the newly added padding on the dashboard panels. Since this padding seemed to cause quite some discussion already (see #15594), I think @alexfrancoeur @elastic/kibana-design and @elastic/kibana-sharing wanted to have another look and consideration about those paddings.

Can anyone of the pinged persons tell what the current state on this is? I would rather not have every visualization type not individually remove it's padding if the padding of the dashboard then will change in the end again?

@kobelb
Copy link
Contributor

kobelb commented Feb 12, 2018

The padding change to Dashboards was intentional based on input from @elastic/kibana-design. We're planning on supporting more granularity for the Dashboard panels (smaller grid sizes) to allow users to size visualizations more easily.

@snide
Copy link
Contributor

snide commented Feb 12, 2018

There's quite a lot variables at play with visualizations in dashboards.

  • The possible margin and borders on the panels if in bordered mode.
  • The padding on the visualizations themselves, which is different from vis to vis.
  • The floating controls that need to be visible and properly z-indexed against who knows what is thrown into them.
  • Individual user sizing that the user sets.
  • Line height and global design changes as we tear out bootstrap and move to EUI.

Changing one tends to break the others. We need to normalize these as best we can. I can put a spec together to define settings for this stuff but it would need to be rigidly followed if we want these all to line up.

And just to be clear, going through that audit and making those changes will inherently cause minor shifts in current layouts. We need to be ok with this and realize the user settings will always have a part to play here.

@jbudz
Copy link
Member Author

jbudz commented Mar 7, 2018

Closing this out as I'm not tracking it. Feel free to ping or take it over

@jbudz jbudz closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants