Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard breadcrumb on edit visualization doesn't work when user doesn't have visualize feature privilege for by value panels #156119

Closed
bhavyarm opened this issue Apr 27, 2023 · 2 comments · Fixed by #156667
Closed

Dashboard breadcrumb on edit visualization doesn't work when user doesn't have visualize feature privilege for by value panels #156119

bhavyarm opened this issue Apr 27, 2023 · 2 comments · Fixed by #156667
Assignees
@stratoula
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
Dashboard

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.7.1

Elasticsearch version: 8.7.1

Browser version: chrome latest

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If user without visualize feature privileges logs in and clicks on edit on a dashboard with by value visualization panels - Kibana displays edit visualization. If you follow that Kibana correctly displays application not found.
But there is also clickable dashboard breadcrumb. Clicking on it doesn't do anything.

Please note for panels by reference Kibana doesn't display edit visualization.

Steps to reproduce:

  1. Make sure you have a dashboard with by value visualize panels
  2. Create an user with a role without access to visualize feature but it has access to dashboard and indices and associate the space with dashboards from step 1
  3. Login with above user
  4. Go to dashboard click on edit and on a by value visualize panel - click on edit visualization
  5. Kibana displays application not found in a new tab but with clickable dashboard breadcrumb
  6. Clicking on that breadcrumb doesn't do anything
not_working_breadcrumb.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues labels Apr 27, 2023
@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@kibanamachine kibanamachine added this to Inbox in Dashboard Apr 27, 2023
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label May 2, 2023
@stratoula
Copy link
Contributor

The best fix here is to not display the edit in lens action when the user doesnt have visualize privileges

@stratoula stratoula self-assigned this May 4, 2023
@stratoula stratoula mentioned this issue May 4, 2023
Merged
1 task
stratoula added a commit that referenced this issue May 5, 2023
@stratoula
[Visualizations][Lens] Hide incompatible actions from the panels (#15…
ac18e8a 
…6667)

## Summary

Closes #156119
Closes #156114

This PR

1. Removes the convert to Lens action if visualize permissions are set
to None
<img width="467" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183482-b6e3cfe9-a77b-44d5-9909-1580c0796db2.png">

2. Removes the edit actions if visualize permisions are set to None
<img width="938" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183601-9a715339-2ab7-47d8-8b89-c10bdb03938e.png">


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
smith pushed a commit to smith/kibana that referenced this issue May 5, 2023
@stratoula @smith
[Visualizations][Lens] Hide incompatible actions from the panels (ela…
7826a39 
…stic#156667)

## Summary

Closes elastic#156119
Closes elastic#156114

This PR

1. Removes the convert to Lens action if visualize permissions are set
to None
<img width="467" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183482-b6e3cfe9-a77b-44d5-9909-1580c0796db2.png">

2. Removes the edit actions if visualize permisions are set to None
<img width="938" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183601-9a715339-2ab7-47d8-8b89-c10bdb03938e.png">


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Dashboard
  
Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Visualizations][Lens] Hide incompatible actions from the panels stratoula/kibana
4 participants
@bhavyarm @elasticmachine @stratoula @kibanamachine