Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations][Lens] Hide incompatible actions from the panels #156667

Merged

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 4, 2023

Summary

Closes #156119
Closes #156114

This PR

  1. Removes the convert to Lens action if visualize permissions are set to None

image

  1. Removes the edit actions if visualize permisions are set to None

image

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +46.0B
visualizations 260.4KB 260.5KB +17.0B
total +63.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 34.7KB 34.8KB +48.0B
visualizations 57.3KB 57.4KB +123.0B
total +171.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.9.0 labels May 4, 2023
@stratoula stratoula marked this pull request as ready for review May 4, 2023 11:49
@stratoula stratoula requested a review from a team as a code owner May 4, 2023 11:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit ac18e8a into elastic:main May 5, 2023
28 checks passed
smith pushed a commit to smith/kibana that referenced this pull request May 5, 2023
…stic#156667)

## Summary

Closes elastic#156119
Closes elastic#156114

This PR

1. Removes the convert to Lens action if visualize permissions are set
to None
<img width="467" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183482-b6e3cfe9-a77b-44d5-9909-1580c0796db2.png">

2. Removes the edit actions if visualize permisions are set to None
<img width="938" alt="image"
src="https://user-images.githubusercontent.com/17003240/236183601-9a715339-2ab7-47d8-8b89-c10bdb03938e.png">


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
4 participants