Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Security Solution] Toast message for snooze notification is incorrect #156143

Closed
sukhwindersingh-qasource opened this issue Apr 28, 2023 · 4 comments · Fixed by #166030
Closed

[RAM][Security Solution] Toast message for snooze notification is incorrect #156143

sukhwindersingh-qasource opened this issue Apr 28, 2023 · 4 comments · Fixed by #166030
Assignees
@Zacqary
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. ui-copy Review of UI copy with docs team is recommended

Comments

@sukhwindersingh-qasource
Copy link

sukhwindersingh-qasource commented Apr 28, 2023 •
edited

Describe the bug:

  • Toast message for snoze notification is incorrect.

Build Details:

Version:8.8.0-SNAPSHOT
Commit:4ef2af355e2ed4697180a2c7e1d6a3d3f0b26bc3
Build:62736

Preconditions

  • Rules should be present.
  • Alerts should be present on kibana instance.

Steps to Reproduce

  • Navigate to Security.
  • Navigate to any rule.
  • Click on the bell icon and click on apply.
  • Notification message shown is "Rule successfully snoozed "

Actual Result

  • Toast message for snoze notification is incorrect.

Expected Result

  • Toast Message shown should be " Rules notification successfully snoozed"
  • Rule is still running only notifications has been snoozed.

Screen-Recording

Rules.-.Kibana.Mozilla.Firefox.2023-04-28.14-14-50.mp4
@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema assigned banderror and unassigned peluja1012 May 2, 2023
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels May 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Rule Management Security Solution Detection Rule Management Feature:Alerting/RulesManagement Issues related to the Rules Management UX and removed triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@banderror banderror changed the title [Security Solution]Toast message for snoze notification is incorrect. [RAM][Security Solution] Toast message for snooze notification is incorrect May 3, 2023
@banderror
Copy link
Contributor

@sukhwindersingh-qasource I think the wording is correct, because "rule snoozing" means "suppressing rule's notification actions, or in other words preventing them from being triggered". It is not assumed that a snoozed rule would stop generating alerts.

Just like with another ticket (#156150 (comment)), I'll redirect this to the Response Ops team and let them decide on the best copy.

cc @XavierM @elastic/response-ops-ram I added this issue to your backlog.

@banderror banderror removed their assignment May 3, 2023
@lcawl lcawl added the ui-copy Review of UI copy with docs team is recommended label May 3, 2023
@Zacqary Zacqary mentioned this issue Sep 7, 2023
Merged
1 task
Zacqary added a commit that referenced this issue Sep 7, 2023
@Zacqary @lcawl
[RAM][Security Solution] Fix rule snooze toast copy (#166030)
649dc49 
## Summary

Fixes #156143

Updates toasts saying `Rule successfully snoozed` to `Rules notification
successfully snoozed`. Does the same for `unsnoozed`.

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. ui-copy Review of UI copy with docs team is recommended
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM][Security Solution] Fix rule snooze toast copy Zacqary/kibana
8 participants
@peluja1012 @Zacqary @banderror @elasticmachine @MadameSheema @lcawl @karanbirsingh-qasource @sukhwindersingh-qasource