Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Security Solution] Fix rule snooze toast copy #166030

Merged
merged 2 commits into from Sep 7, 2023
Merged

[RAM][Security Solution] Fix rule snooze toast copy #166030

merged 2 commits into from Sep 7, 2023

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Sep 7, 2023

Summary

Fixes #156143

Updates toasts saying Rule successfully snoozed to Rules notification successfully snoozed. Does the same for unsnoozed.

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.11.0 labels Sep 7, 2023
@Zacqary Zacqary requested a review from a team as a code owner September 7, 2023 21:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Zacqary @lcawl
Apply suggestions from code review
e2d6787 
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl
lcawl approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM, thanks!

@Zacqary Zacqary enabled auto-merge (squash) September 7, 2023 22:18
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 7, 2023 •
edited

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +112.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 649dc49 into elastic:main Sep 7, 2023
32 of 34 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAM][Security Solution] Toast message for snooze notification is incorrect
6 participants
@Zacqary @elasticmachine @apmmachine @kibana-ci @lcawl @kibanamachine