Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aggbased] Threshold line doesn't render on XY charts #158343

Closed
stratoula opened this issue May 24, 2023 · 1 comment · Fixed by #158917
Closed

[Aggbased] Threshold line doesn't render on XY charts #158343

stratoula opened this issue May 24, 2023 · 1 comment · Fixed by #158917
Assignees
@stratoula
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
Lens

Comments

@stratoula
Copy link
Contributor

Kibana version:
8.7++

Describe the bug:
In a line chart there is the option to add a threshold line on a static value. This is broken, it doesn't render any more
image

Any additional context:
The workaround is to use Lens reference lines instead.

image
@stratoula stratoula added the bug Fixes for quality problems that affect the customer experience label May 24, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 24, 2023
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed needs-team Issues missing a team label labels May 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@kibanamachine kibanamachine added this to Long-term goals in Lens May 24, 2023
@stratoula stratoula self-assigned this Jun 2, 2023
@stratoula stratoula mentioned this issue Jun 2, 2023
Merged
1 task
stratoula added a commit that referenced this issue Jun 2, 2023
@stratoula
[XY] Fixes the threshold visibility (#158917)
a584986 
## Summary

Closes #158343

Fixes the broken reference line in aggbased xy charts.

<img width="1715" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/ae48f0b8-475a-44e2-866a-c56e9da8e8b0">

The problem was the default here, apparently the expressions fail when
the default is an empty string. The expression was failing and as a
result the reference line was never rendered

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jun 5, 2023
@stratoula @cqliu1
[XY] Fixes the threshold visibility (elastic#158917)
a8a29a4 
## Summary

Closes elastic#158343

Fixes the broken reference line in aggbased xy charts.

<img width="1715" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/ae48f0b8-475a-44e2-866a-c56e9da8e8b0">

The problem was the default here, apparently the expressions fail when
the default is an empty string. The expression was failing and as a
result the reference line was never rendered

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
sloanelybutsurely pushed a commit to sloanelybutsurely/kibana that referenced this issue Jun 6, 2023
@stratoula
[XY] Fixes the threshold visibility (elastic#158917)
e78366c 
## Summary

Closes elastic#158343

Fixes the broken reference line in aggbased xy charts.

<img width="1715" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/ae48f0b8-475a-44e2-866a-c56e9da8e8b0">

The problem was the default here, apparently the expressions fail when
the default is an empty string. The expression was failing and as a
result the reference line was never rendered

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Long-term goals
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[XY] Fixes the threshold visibility stratoula/kibana
2 participants
@elasticmachine @stratoula