[XY] Fixes the threshold visibility #158917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
stratoula
added
release_note:fix
Feature:XYAxis
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jun 5, 2023
## Summary Closes elastic#158343 Fixes the broken reference line in aggbased xy charts. <img width="1715" alt="image" src="https://github.com/elastic/kibana/assets/17003240/ae48f0b8-475a-44e2-866a-c56e9da8e8b0"> The problem was the default here, apparently the expressions fail when the default is an empty string. The expression was failing and as a result the reference line was never rendered ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
sloanelybutsurely
pushed a commit
to sloanelybutsurely/kibana
that referenced
this pull request
Jun 6, 2023
## Summary Closes elastic#158343 Fixes the broken reference line in aggbased xy charts. <img width="1715" alt="image" src="https://github.com/elastic/kibana/assets/17003240/ae48f0b8-475a-44e2-866a-c56e9da8e8b0"> The problem was the default here, apparently the expressions fail when the default is an empty string. The expression was failing and as a result the reference line was never rendered ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #158343
Fixes the broken reference line in aggbased xy charts.
The problem was the default here, apparently the expressions fail when the default is an empty string. The expression was failing and as a result the reference line was never rendered
Checklist