Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor "No results" screen for visualizations #16640

Closed
timroes opened this issue Feb 9, 2018 · 1 comment
Closed

Fix and refactor "No results" screen for visualizations #16640

timroes opened this issue Feb 9, 2018 · 1 comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 9, 2018

The "No results" screen, that should be shown for visualizations, if no data has been found, requires some refactoring and fixing.

There are currently two implementations - one for vislib visualizations and one in <visualization> for all visualizations. The later doesn't work properly. We should at least fix the following issues:

  • Only have one implementation, not two
  • <visualization> only works if there is no response handler. Instead the response handler should tell us if there has been results.
  • Remove the dead vis.params.handleNoResults check. This isn't used anywhere.

I think a visualization type should still be able to specify whether it wants to handle no data scenario itself or want Kibana to show the default message.

This would also fix #16420

@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Feb 9, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes timroes removed the bug Fixes for quality problems that affect the customer experience label May 15, 2019
@sulemanof
Copy link
Contributor

Clothing this, since we have the only implementation of No results found message in VisualizationNoResults component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants