fixing missing value display for number fields #16644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
review
Feature:Visualizations
|
I think this doesn't fix #16640, but rather #16420 which is the specific issue for the metrics visualization. I am also wondering: do we really need to create that metric vis specific "no data solution" that has been broken "forever" in a patch version? Or could we wait for the next minor version to fix #16640 and have a proper solution for all visualizations? (At least if we merge this, we should think about removing that quick solution in favor of the general solution once #16640 is solved.) |
|
Jenkins, test this |
ppisljar
force-pushed
the
fix/metricAggSupport
branch
from
8deb3a9
to
a648f18
Compare
ppisljar
force-pushed
the
fix/metricAggSupport
branch
from
a648f18
to
358ac33
Compare
ppisljar
changed the title
ppisljar
force-pushed
the
fix/metricAggSupport
branch
2 times, most recently
from
b71afab
to
5c68a62
Compare
💚 Build Succeeded |
|
@timroes what do you think ? |
timroes
reviewed
May 4, 2018
| @@ -65,6 +65,11 @@ export class MetricVisComponent extends Component { | |||
| return isColorDark(parseInt(color[1]), parseInt(color[2]), parseInt(color[3])); | |||
| } | |||
|
|
|||
| _getFormattedValue(fieldFormatter, value) { | |||
| if (!value && isNaN(value)) return '-'; | |||
There was a problem hiding this comment.
We could just use if(_.isNaN(value)) here
timroes
approved these changes
May 4, 2018
ppisljar
force-pushed
the
fix/metricAggSupport
branch
from
5c68a62
to
98a7b9d
Compare
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
May 8, 2018
ppisljar
added a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles missing values by showing - (using number field formatters on them caused errors)