[DataViews] Implement DataViewLazy class based on AbstractDataView #167750
Assignees
Labels
Feature:Data Views
Data Views code and UI - index patterns before 8.0
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
loe:large
Large Level of Effort
Team:DataDiscovery
Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
Comments
kertal
added
loe:needs-research
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
changed the title
kertal
changed the title
kertal
added
loe:large
mattkime
added a commit
that referenced
this issue
Apr 3, 2024
## Summary Part 1 of #178594 Initial implementation of DataViewLazy class - an alternative DataView implementation that doesn't load the full field list on initial creation. ``` Implements DataViewLazy (variations from DataView class) - getFields ({ mapped = true, scripted = true, runtime = true, fieldName, forceRefresh = false, unmapped, indexFilter, metaFields = true }) => Promise<{ getFieldMap: () => Record<string, DataViewField>; getFieldMapSorted: () => Record<string, DataViewField> }> - getRuntimeFields({ fieldName = ['*'] }) => Record<string, DataViewField> - getScriptedFields({ fieldName = ['*'] }) => Record<string, DataViewField> - getFieldByName (string) => Promise<DataViewField> - toSpec (same params as getFields) => Promise<DataViewSpec> other notable changes using DataViewLazy over DataView - won't throw if index pattern fails to match - by default toSpec doesn't return fields, must pass in parameters for requested fields --- DataViews service additions - toDataView: (toDataView: DataViewLazy) => Promise<DataView>; - toDataViewLazy: (dataView: DataView) => Promise<DataViewLazy>; - getAllDataViewLazy: () => Promise<DataViewLazy[]>; - getDataViewLazy: (id: string) => Promise<DataViewLazy>; - createDataViewLazy: (spec: DataViewSpec) => Promise<DataViewLazy>; - createAndSaveDataViewLazy: (spec: DataViewSpec, override?: boolean) => Promise<DataViewLazy>; - getDefaultDataViewLazy: () => Promise<DataViewLazy | null>; ``` Closes #176426 and #167750 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
Closed by #173948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When DataViewAbstract is implemented (#167736), the decoupling of the fields fetching for DataViews can continued by implementing a new
DataViewLazyclass. This will provide consumers of this class to get DataViews without automatic field fetching. This is beneficial to improve the performance when data views are consumed.A potential improvement
In Discover/Lens we currently fetch a data view with all fields, and additionally there's a request for the field list with an indexFilter, aiming the find the fields of indices that match a give query. This fields are then displayed in the "Available fields" list. With the new
DataViewLazyclass, we can optimize this, by e.g. initially just fetch the fields that match the indexFilter, and load all fields on demand. What's more, currently the fetching of fields is blocking the UI when Discover is loaded, or the data view is being switched to a new one. Since field loading with the new class fields is decoupled, we can provide a more responsive UX.The text was updated successfully, but these errors were encountered: