Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataViews] Create AbstractDataView class #167736

Closed
Tracked by #167735
, #167595
...
kertal opened this issue Oct 2, 2023 · 2 comments
Closed
Tracked by #167735
, #167595
...

[DataViews] Create AbstractDataView class #167736

kertal opened this issue Oct 2, 2023 · 2 comments
Assignees
@mattkime
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Oct 2, 2023

Create a AbstractDataView class which provides all functionality that doesn't expect a full field list upon object creation.

The code remaining in the DataView class either loads the field list or depends upon the loaded field list.
@kertal kertal added refactoring Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the loe:medium Medium Level of Effort label Oct 2, 2023
@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Oct 2, 2023
@kertal kertal mentioned this issue Oct 2, 2023
Closed
This was referenced Oct 2, 2023
Closed
Closed
@davismcphee
Copy link
Contributor

@mattkime can we close this with #161611 or is there remaining work to be done for this issue?

@mattkime mattkime mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattkime @kertal @elasticmachine @davismcphee