Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Improve editor action buttons #180911

Open
yuliacech opened this issue Apr 16, 2024 · 1 comment
Open

[Console] Improve editor action buttons #180911

yuliacech opened this issue Apr 16, 2024 · 1 comment
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Apr 16, 2024 •
edited
Loading

Follow up to #179808

Improvements suggested in the code review @MichaelMarcialis

  • Change the "send request" and the "context menu" buttons from EuiLink with an icon to EuiButtonIcon. The buttons will need some css adjustments to be aligned on the editor line
  • When a selected request is not complete, it's not possible to open a documentation link, so this button might need to be hidden or disabled. The same could be applied to other buttons as well.
  • The popover doesn't close automatically
Screen.Recording.2024-04-17.at.17.11.33.mov
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

This was referenced Apr 16, 2024
Closed
Merged
Merged
yuliacech added a commit that referenced this issue Apr 22, 2024
@yuliacech @kibanamachine
[Console] Implement documentation action button (#181057)
e18d19f 
## Summary
Closes #180209 

This PR implements the "view documentation" button in the new Monaco
editor in Console. The code re-use the existing autocomplete
functionality and gets the documentation link for the current request
from autocomplete definitions. The current request is the 1st request of
the user selection in the editor. The link is opened in the new tab and
if no link is available or the request is unknown, then nothing happens
(existing functionality, we might want to hide the button in that case
in a [follow up work](#180911))

### Screen recording 



https://github.com/elastic/kibana/assets/6585477/56ea016c-02b6-4134-97b7-914204557d61

### How to test
1. Add `console.dev.enableMonaco: true` to the `config/kibana.dev.yml`
file
2. Start Kibana and ES locally
3. Navigate to the Dev tools Console and try using the "view
documentation" button for various requests

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuliacech @elasticmachine