Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<UserAvatarTip/> doesn't handle long names well #182561

Closed
Dosant opened this issue May 3, 2024 · 2 comments · Fixed by #184318
Closed

<UserAvatarTip/> doesn't handle long names well #182561

Dosant opened this issue May 3, 2024 · 2 comments · Fixed by #184318
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/User Profile good first issue low hanging fruit Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented May 3, 2024

UserAvatarTip could be improved for handling longer names

image

image

cc @elastic/kibana-security

Originally posted by @Heenawter in #182256 (comment)
@Dosant Dosant added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/User Profile bug Fixes for quality problems that affect the customer experience labels May 3, 2024
@Dosant Dosant mentioned this issue May 8, 2024
Closed
@Dosant Dosant added the good first issue low hanging fruit label May 8, 2024
@kawaljen
Copy link

hey can i work on this one ?
Also would you prefer longer tip or ellipsis truncation ?

@Dosant Dosant self-assigned this May 28, 2024
@Dosant Dosant mentioned this issue May 28, 2024
Merged
@Dosant Dosant added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label May 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Dosant added a commit that referenced this issue Jun 5, 2024
@Dosant
[UsersProfilePopover] Fix email sometimes is not visible (#184318)
db9e530 
## Summary

fix #182945


- This fixes `UsersProfilePopover` to always show email on the 2nd line.
To keep the list virtualized **had to increase the height a bit for
every row**

Before:


![image](https://github.com/elastic/kibana/assets/7784120/ee42530f-9b39-4139-bd81-12c0a8fd6498)


After:

![Screenshot 2024-05-27 at 15 28
05](https://github.com/elastic/kibana/assets/7784120/5d869cf3-194f-4b08-b4a8-945d5904452e)


- Also adds email in a label to make it appear in a browser tooltip 

![Screenshot 2024-05-27 at 16 20
12](https://github.com/elastic/kibana/assets/7784120/a9687ec2-a92a-44e9-a64d-e64a4e87b497)


- Also fixes #182561 and adds
email to Avatar "name" so it appears in a native tooltip

![Screenshot 2024-05-28 at 15 57
21](https://github.com/elastic/kibana/assets/7784120/67b0bb65-4ce4-4561-85cc-356175bc86c2)



- Increase popover width in TableListView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/User Profile good first issue low hanging fruit Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UsersProfilePopover] Fix email sometimes is not visible Dosant/kibana
3 participants
@kawaljen @Dosant @elasticmachine