Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UsersProfilePopover] Email sometimes is not visible #182945

Closed
Dosant opened this issue May 8, 2024 · 4 comments · Fixed by #184318
Closed

[UsersProfilePopover] Email sometimes is not visible #182945

Dosant opened this issue May 8, 2024 · 4 comments · Fixed by #184318
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/User Profile Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented May 8, 2024

In #182155 we improved the display of longer names and emails, so that they are nicely truncated when they don't fit.

image

However, this is not ideal, and we should try to display an email

@MichaelMarcialis:

Apologies for the late reply. Generally speaking, I think truncation to ellipses is a fine way to address a lack of horizontal space. However, it would be unfortunate to lose all mention of an accompanying email address, if that is indeed what is happening here (as that may be important in helping identify users).

Is this always the maximum width of this filter's popover? Perhaps we can increase this a bit to offer a bit more breathing room? Additionally, off the top of my head I'd propose one of the following:

Option 1: Move the optionally appearing email address to a line below the user name and align the text left (so it aligns nicely with the user name above it). In doing so, I'd also recommend reducing the font size to its extra small variant. This way, both pieces of text can have text truncation applied, without losing either entirely.

Option 2: If it is preferable to keep the user name and email address on the same line, apply a reasonable maximum width to the email address container, have the user name container fill the remaining available horizontal space and set both to truncate their text (so both are visible/represented, even if truncated heavily).

Thoughts?

@azasypkin:

Option 1: Move the optionally appearing email address to a line below the user name and align the text left (so it aligns nicely with the user name above it). In doing so, I'd also recommend reducing the font size to its extra small variant. This way, both pieces of text can have text truncation applied, without losing either entirely.

Not a UX/UI person or anything, but I really like this option from a functional perspective :) It's surprising how many namesakes a large organization might have, and having visibility to email might be vital.


also related #182561

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Security/User Profile labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@H0onnn
Copy link

H0onnn commented May 9, 2024

@Dosant Hello, Can I solve this problem ?

@Dosant Dosant self-assigned this May 22, 2024
@Dosant Dosant removed the good first issue low hanging fruit label May 22, 2024
@Dosant
Copy link
Contributor Author

Dosant commented May 22, 2024

  • also consider increasing width (make sure it doesn't overflow on smaller screen)
  • make sure that the tooltip includes the email

Dosant added a commit that referenced this issue Jun 5, 2024
## Summary

fix #182945


- This fixes `UsersProfilePopover` to always show email on the 2nd line.
To keep the list virtualized **had to increase the height a bit for
every row**

Before:


![image](https://github.com/elastic/kibana/assets/7784120/ee42530f-9b39-4139-bd81-12c0a8fd6498)


After:

![Screenshot 2024-05-27 at 15 28
05](https://github.com/elastic/kibana/assets/7784120/5d869cf3-194f-4b08-b4a8-945d5904452e)


- Also adds email in a label to make it appear in a browser tooltip 

![Screenshot 2024-05-27 at 16 20
12](https://github.com/elastic/kibana/assets/7784120/a9687ec2-a92a-44e9-a64d-e64a4e87b497)


- Also fixes #182561 and adds
email to Avatar "name" so it appears in a native tooltip

![Screenshot 2024-05-28 at 15 57
21](https://github.com/elastic/kibana/assets/7784120/67b0bb65-4ce4-4561-85cc-356175bc86c2)



- Increase popover width in TableListView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/User Profile Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants