-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Make existing OpenAPI specs for Detections API documentation-ready #183702
Comments
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Hi @banderror & @maximpn, as part of a Docs OnWeek project, I made some editorial suggestions to the Detections API specs, mostly adding missing operation summaries and descriptions, or making changes to existing ones to align with our guidelines. Letting you know as this partially addresses some of the work planned in this issue. Here's the related PR: #187224. |
@natasha-moore-elastic Thanks for this contribution, I might be able to take a quick look this week, and @maximpn will review the PR in detail when he's back from PTO. |
## Summary Resolves elastic/docs-projects#219 by improving the Detections API docs content. Adds missing and improves existing operation summaries and operation descriptions. Also addresses some of the work planned in #183702. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Epic: https://github.com/elastic/security-team/issues/9398
Depends on: #183661, #183701
Deadline: Sep 24, 2024 (see milestones in https://github.com/elastic/security-team/issues/9400)
Summary
As part of the Serverless project, we need to make sure OpenAPI specs for all public Detections API endpoints are polished and ready to be published on a documentation website. Please look for more context in the epic, and please find below what needs to be done exactly.
API endpoints
The following public API endpoints are available in both Serverless and ESS:
GET /api/detection_engine/rules
POST /api/detection_engine/rules
PUT /api/detection_engine/rules
PATCH /api/detection_engine/rules
DELETE /api/detection_engine/rules
POST /api/detection_engine/rules/_bulk_action
POST /api/detection_engine/rules/_export
POST /api/detection_engine/rules/_import
GET /api/detection_engine/rules/_find
GET /api/detection_engine/tags
GET /api/detection_engine/rules/prepackaged/_status
PUT /api/detection_engine/rules/prepackaged
POST /api/detection_engine/rules/preview
POST /api/detection_engine/signals/status
POST /api/detection_engine/signals/tags
POST /api/detection_engine/signals/search
POST /api/detection_engine/signals/assignees
GET /api/detection_engine/privileges
POST /api/detection_engine/rules/{id}/exceptions
The following public API endpoints are available in ESS only:
POST /api/detection_engine/rules/_bulk_create
PUT /api/detection_engine/rules/_bulk_update
PATCH /api/detection_engine/rules/_bulk_update
DELETE /api/detection_engine/rules/_bulk_delete
POST /api/detection_engine/rules/_bulk_delete
GET /api/detection_engine/signals/migration_status
POST /api/detection_engine/signals/migration
POST /api/detection_engine/signals/finalize_migration
POST /api/detection_engine/index
GET /api/detection_engine/index
DELETE /api/detection_engine/index
To do
For all the Detections API endpoints (including those above), in the corresponding OpenAPI specification files, please:
Ask @maximpn to provide you with an example of a polished and documentation-ready OpenAPI spec. Please also ask @maximpn for a link to the generated API reference documentation (at the time of creating this ticket, it didn't exist).
The text was updated successfully, but these errors were encountered: