Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Serverless Security Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams·ts - Serverless Common UI - Management Index Management Data Streams allows to update data retention #186243

Closed
kibanamachine opened this issue Jun 14, 2024 · 9 comments · Fixed by #186420
Closed

Failing test: Serverless Security Functional Tests - Common Group 1.x-pack/test_serverless/functional/test_suites/common/management/index_management/data_streams·ts - Serverless Common UI - Management Index Management Data Streams allows to update data retention #186243

kibanamachine opened this issue Jun 14, 2024 · 9 comments · Fixed by #186420
Assignees
@ElenaStoeva
Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 14, 2024 •
edited
Loading

A test failed on a tracked branch

Error: retry.try reached timeout 120000 ms
TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="manageDataStreamButton"])
Wait timed out after 10027ms
    at /opt/buildkite-agent/builds/bk-agent-prod-gcp-1718371601821851720/elastic/kibana-elasticsearch-serverless-verify-and-promote/kibana/node_modules/selenium-webdriver/lib/webdriver.js:911:22
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:84:7)
    at RetryService.try (retry.ts:51:12)
    at Proxy.clickByCssSelector (find.ts:419:5)
    at TestSubjects.click (test_subjects.ts:168:5)
    at Context.<anonymous> (data_streams.ts:106:7)
    at Object.apply (wrap_function.js:73:16)

First failure: kibana-elasticsearch-serverless-verify-and-promote - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 14, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 14, 2024
@kibanamachine kibanamachine added failed-es-promotion Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 14, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-serverless-verify-and-promote - main

@alisonelizabeth
Copy link
Contributor

Caused by elastic/elasticsearch#108745

@ElenaStoeva ElenaStoeva mentioned this issue Jun 18, 2024
Merged
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 24, 2024
@ElenaStoeva @bhapas
[Index Management] Disable data stream stats in serverless (elastic#1…
38740a5 
…86420)

Closes elastic#184671
Fixes elastic#186245
Fixes elastic#186243
Fixes elastic#186242

## Summary

This PR disables the data stream stats API request in serverless and the
stats toggle in the Data stream list view. It adds a new config
`enableDataStreamStats` and removes the `enableDataStreamsStorageColumn`
one as it is now redundant (since the storage size property is part of
the data stream stats).

### How to test:

**In serverless:**
1. Start serverless Es and Kibana
2. Go to Stack Management -> Index Management and open the Data Streams
tab.
3. Verify that the stats toggle is not displayed and the data stream
detail panels don't include any of the stats (`storageSizeBytes` and
`maxTimeStamp`).

**In stateful:**
1. Start stateful Es and Kibana
2. Go to Stack Management -> Index Management and open the Data Streams
tab.
3. Verify that the stats toggle is displayed and switching it adds the
stats columns to the table.
4. Verify that the data stream detail panels include the stats.


<!--
### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Index Management] Disable data stream stats in serverless ElenaStoeva/kibana
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @ElenaStoeva