Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the search button in dashboard no longer forces refresh #23329

Closed
lukasolson opened this issue Sep 19, 2018 · 16 comments
Closed

Clicking the search button in dashboard no longer forces refresh #23329

lukasolson opened this issue Sep 19, 2018 · 16 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features PR sent regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@lukasolson
Copy link
Member

lukasolson commented Sep 19, 2018

As of 6.4.0, when you create a dashboard, clicking on the search button no longer forces a refresh (when you haven't updated the query). It does in Visualize and Discover, and should in Dashboard as well.

bad

/cc @elastic/kibana-app

@lukasolson lukasolson added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 19, 2018
@stacey-gammon
Copy link
Contributor

I'm guessing this is only if there are no changes from the previous search? So if you added in a filter and then clicked search, it would refresh?

@lukasolson
Copy link
Member Author

@stacey-gammon That's correct, I'll update the PR description.

@trevan
Copy link
Contributor

trevan commented Sep 26, 2018

If you have a saved search on the dashboard, the loading bar shows up. But without a saved search, it doesn't show any indication of refresh.

@adriankirchner
Copy link

I'm not sure if #23704 from @Bargs should've fixed this issue, but it still exists in v6.5.0. Will #25563 address the non-functional refresh button?

JFYI

Kibana version: 6.5.0
Elasticsearch version: 6.5.0
Server OS version: Ubuntu 16.04.5 LTS
Browser version: Google Chrome 70.0.3538.102
Browser OS version: macOS 10.14.1 (18B75)

@Bargs
Copy link
Contributor

Bargs commented Nov 19, 2018

As far as I can tell, this issue is unrelated to the query bar itself so I wouldn't expect #23704 or #25563 to fix it. The query bar's onSubmit callback is firing correctly. The refresh method on dashboard's scope is executed, calling courier.fetch, but no search request it sent. I haven't debugged further than that, but it seems like a change to dashboard or courier must have broken something.

@TheBronx
Copy link

When the button says "Refresh" it never works for me. It only works when it says "Update" (when you modify the query).

I am using Kibana OSS v6.5.1.

I do not see a single network call on Firefox when clicking the Refresh button. It does nothing.
I have tried Chrome too, same result.

I've found that the Refresh button works on Discover and Visualize, the problem is when you are on a Dashboard.

@Jamalarm
Copy link

Can confirm this issue is also present in Elastic Cloud hosted clusters, We are experiencing it on 6.5.1

@linuxcomputergeek
Copy link

It also appears that auto refresh is no longer refreshing on the specified interval.

Tested in Kibana Basic X-Pack 6.4.2 and Kibana Platinum X-Pack 6.5.0

@lukasolson
Copy link
Member Author

@linuxcomputergeek I believe that was fixed in #26088

@chernecov
Copy link

@lukasolson same happens for me in slightly different context and versions:
#27042

@chernecov
Copy link

@TheBronx, do you have exactly the same issue as #27042 ?

@TheBronx
Copy link

@TheBronx, do you have exactly the same issue as #27042 ?

Yes. I've updated Kibana 6.5.1 OSS to v6.5.2 Standard and the bug is still present. Behavior is the same as #27042

@lukasolson
Copy link
Member Author

Assuming this was introduced in #19172.

@aditragh
Copy link

@stacey-gammon any ETA on when this will be backported to version 6.4 ?

@stacey-gammon
Copy link
Contributor

It won't be @aditragh - #26088 is tagged as 6.5.2. We won't backport to 6.4.

@funbrain
Copy link

funbrain commented Apr 9, 2019

same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features PR sent regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests