Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] eCommerce Sample Workpad not loading #27162

Closed
clintandrewhall opened this issue Dec 13, 2018 · 6 comments · Fixed by #27171
Closed

[Canvas] eCommerce Sample Workpad not loading #27162

clintandrewhall opened this issue Dec 13, 2018 · 6 comments · Fixed by #27171
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Canvas PR sent Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.6.0
Projects
Canvas

Comments

@clintandrewhall
Copy link
Contributor

In master, the eCommerce workpad is still failing with regeneratorRuntime errors. This smells of a babel-polyfill failure. Creating this issue to track.
@clintandrewhall clintandrewhall added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Dec 13, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1
Copy link
Contributor

cqliu1 commented Dec 13, 2018

It appears to throw in common functions that use async/await executing on the server. This affects if, case, and switch.

@clintandrewhall clintandrewhall mentioned this issue Dec 13, 2018
Merged
2 tasks
@clintandrewhall
Copy link
Contributor Author

This is caused by kbn-interpreter:

https://github.com/elastic/kibana/blob/master/packages/kbn-interpreter/src/server/server_registries.js#L65

This deletes regeneratorRuntime which causes these to fail.

@w33ble
Copy link
Contributor

w33ble commented Dec 13, 2018

More fallout from #26068 😞

@ppisljar
Copy link
Member

any reason we pollute the global namespace ?

@clintandrewhall
Copy link
Contributor Author

One man's "pollute" is another man's "babel-polyfill". I assume you're familiar with the package, but if not: https://babeljs.io/docs/en/babel-polyfill

@ppisljar ppisljar mentioned this issue Dec 17, 2018
Closed
7 tasks
@spalger spalger mentioned this issue Dec 17, 2018
Merged
@w33ble w33ble mentioned this issue Dec 26, 2018
Closed
w33ble pushed a commit that referenced this issue Dec 28, 2018
@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (#2…
3d96469 
…7171)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves #27162
w33ble pushed a commit to w33ble/kibana that referenced this issue Dec 28, 2018
@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (el…
f1faef6 
…astic#27171)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves elastic#27162
w33ble pushed a commit to w33ble/kibana that referenced this issue Dec 28, 2018
@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (el…
02803a2 
…astic#27171)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves elastic#27162
w33ble added a commit that referenced this issue Dec 28, 2018
@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (#2…
ffe58f4 
…7171) (#27852)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves #27162
w33ble added a commit that referenced this issue Dec 28, 2018
@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (#2…
f07987e 
…7171) (#27851)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves #27162
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this issue Jan 2, 2019
@clintandrewhall
[interpreter/loadPlugins] avoid deleting globals added by plugins (el…
6651806 
…astic#27171)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves elastic#27162
@kibanamachine kibanamachine added this to Inbox in Canvas Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Canvas PR sent Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.6.0
Projects
No open projects
Canvas
  
Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[interpreter/loadPlugins] avoid deleting globals added by plugins spalger/kibana
6 participants
@clintandrewhall @w33ble @cqliu1 @marius-dr @ppisljar @elasticmachine