Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] [interpreter/loadPlugins] avoid deleting globals added by plugins (#27171) #27851

Merged
merged 1 commit into from
Dec 28, 2018
Merged

[6.x] [interpreter/loadPlugins] avoid deleting globals added by plugins (#27171) #27851

merged 1 commit into from
Dec 28, 2018

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Dec 28, 2018

Backports the following commits to 6.x:

@w33ble
[interpreter/loadPlugins] avoid deleting globals added by plugins (el…
f1faef6 
…astic#27171)

Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves elastic#27162
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@w33ble w33ble merged commit f07987e into elastic:6.x Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w33ble @elasticmachine